pythonPackages.matplotlib: put tests in separate output #19870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aherrmann, @rycee and @domenkozar to be potential reviewers. |
FRidh
changed the title
rycee
reviewed
Oct 25, 2016
| wrapPythonPrograms | ||
| '' + lib.optionalString catchConflicts '' | ||
| # check if we have two packages with the same name in closure and fail | ||
| # this shouldn't happen, something went wrong with dependencies specs | ||
| ${python.interpreter} ${./catch_conflicts.py} | ||
| ''; | ||
| '' + attrs.postFixup or ''''; |
There was a problem hiding this comment.
I think "" is more clear than ''''.
There was a problem hiding this comment.
yes, or maybe + optional hasattr "postFixup" attrs
|
Thanks for spending time on this! |
|
hmm, unfortunately this isn't working yet for matplotlib. The tests ( |
|
Since 678b917f000a6b6a8affab1c5e69f49de2c5543a was needed elsewhere I pushed it as 85a87f5 |
FRidh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)