-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildPythonPackage uses postFixup for itself #9204
Labels
Comments
Agreed, we can't use |
(triage) has this changed? |
Nope. buildPythonPackage still wraps programs in postFixup. |
37 tasks
7 tasks
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this issue
May 31, 2024
(cherry picked from commit 85a87f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was under the impression that pre/post hooks were available to users. But in the case of python packages, or rather the standard buildPythonPackage function, uses postFixup for itself. This makes it a bit cumbersome if you want to do something custom after the wrapping has taken place (without manually copying the postFixup hook from buildPythonPackage...).
I don't know whether this is best fixed by adding another kind of phase, or if the wrapping currently done in postFixup should be moved to the end of installPhase (before calling postInstall).
The use case I had in mind was to generate bash-completion files for python programs that use "click" or "argh". But to do that we need to be able to run the wrapped python program at the end of the build/install phase.
The text was updated successfully, but these errors were encountered: