Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.nscd: init, remove nixosTests.resolv #194916

Merged
merged 3 commits into from
Oct 14, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nixos/tests/all-tests.nix
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@ in {
non-default-filesystems = handleTest ./non-default-filesystems.nix {};
noto-fonts = handleTest ./noto-fonts.nix {};
novacomd = handleTestOn ["x86_64-linux"] ./novacomd.nix {};
nscd = handleTest ./nscd.nix {};
nsd = handleTest ./nsd.nix {};
nzbget = handleTest ./nzbget.nix {};
nzbhydra2 = handleTest ./nzbhydra2.nix {};
Expand Down Expand Up @@ -529,7 +530,6 @@ in {
rasdaemon = handleTest ./rasdaemon.nix {};
redis = handleTest ./redis.nix {};
redmine = handleTest ./redmine.nix {};
resolv = handleTest ./resolv.nix {};
restartByActivationScript = handleTest ./restart-by-activation-script.nix {};
restic = handleTest ./restic.nix {};
retroarch = handleTest ./retroarch.nix {};
Expand Down
122 changes: 122 additions & 0 deletions nixos/tests/nscd.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
import ./make-test-python.nix ({ pkgs, ... }:
let
# build a getent that itself doesn't see anything in /etc/hosts and
# /etc/nsswitch.conf, by using libredirect to steer its own requests to
# /dev/null.
# This means is /has/ to go via nscd to actuallly resolve any of the
# additionally configured hosts.
getent' = pkgs.writeScript "getent-without-etc-hosts" ''
export NIX_REDIRECTS=/etc/hosts=/dev/null:/etc/nsswitch.conf=/dev/null
export LD_PRELOAD=${pkgs.libredirect}/lib/libredirect.so
exec getent $@
'';
in
{
name = "nscd";

nodes.machine = { pkgs, ... }: {
imports = [ common/user-account.nix ];
networking.extraHosts = ''
2001:db8::1 somehost.test
192.0.2.1 somehost.test
'';

specialisation = {
withUnscd.configuration = { ... }: {
services.nscd.package = pkgs.unscd;
};
};
};

testScript = { nodes, ... }:
let
specialisations = "${nodes.machine.system.build.toplevel}/specialisation";
in
''
# Regression test for https://github.com/NixOS/nixpkgs/issues/50273
def test_dynamic_user():
with subtest("DynamicUser actually allocates a user"):
assert "iamatest" in machine.succeed(
"systemd-run --pty --property=Type=oneshot --property=DynamicUser=yes --property=User=iamatest whoami"
)

# Test resolution of somehost.test with getent', to make sure we go via nscd
def test_host_lookups():
with subtest("host lookups via nscd"):
# ahosts
output = machine.succeed("${getent'} ahosts somehost.test")
assert "192.0.2.1" in output
assert "2001:db8::1" in output

# ahostsv4
output = machine.succeed("${getent'} ahostsv4 somehost.test")
assert "192.0.2.1" in output
assert "2001:db8::1" not in output

# ahostsv6
output = machine.succeed("${getent'} ahostsv6 somehost.test")
assert "192.0.2.1" not in output
assert "2001:db8::1" in output

# reverse lookups (hosts)
assert "somehost.test" in machine.succeed("${getent'} hosts 2001:db8::1")
assert "somehost.test" in machine.succeed("${getent'} hosts 192.0.2.1")

# Test host resolution via nss modules works
# We rely on nss-myhostname in this case, which resolves *.localhost and
# _gateway.
# We don't need to use getent' here, as non-glibc nss modules can only be
# discovered via nscd.
def test_nss_myhostname():
with subtest("nss-myhostname provides hostnames (ahosts)"):
# ahosts
output = machine.succeed("getent ahosts foobar.localhost")
assert "::1" in output
assert "127.0.0.1" in output

# ahostsv4
output = machine.succeed("getent ahostsv4 foobar.localhost")
assert "::1" not in output
assert "127.0.0.1" in output

# ahostsv6
output = machine.succeed("getent ahostsv6 foobar.localhost")
assert "::1" in output
assert "127.0.0.1" not in output

# ahosts
output = machine.succeed("getent ahosts _gateway")

# returns something like the following:
# 10.0.2.2 STREAM _gateway
# 10.0.2.2 DGRAM
# 10.0.2.2 RAW
# fe80::2 STREAM
# fe80::2 DGRAM
# fe80::2 RAW

# Verify we see both ip addresses
assert "10.0.2.2" in output
assert "fe80::2" in output

start_all()
machine.wait_for_unit("default.target")

# Test all tests with glibc-nscd.
test_dynamic_user()
test_host_lookups()
test_nss_myhostname()

with subtest("unscd"):
machine.succeed('${specialisations}/withUnscd/bin/switch-to-configuration test')
machine.wait_for_unit("default.target")

# known to fail, unscd doesn't load external NSS modules
# test_dynamic_user()

test_host_lookups()

# known to fail, unscd doesn't load external NSS modules
# test_nss_myhostname()
'';
})
46 changes: 0 additions & 46 deletions nixos/tests/resolv.nix

This file was deleted.

6 changes: 0 additions & 6 deletions nixos/tests/systemd.nix
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,6 @@ import ./make-test-python.nix ({ pkgs, ... }: {
machine.succeed("test -e /home/alice/user_conf_read")
machine.succeed("test -z $(ls -1 /var/log/journal)")

# Regression test for https://github.com/NixOS/nixpkgs/issues/50273
with subtest("DynamicUser actually allocates a user"):
assert "iamatest" in machine.succeed(
"systemd-run --pty --property=Type=oneshot --property=DynamicUser=yes --property=User=iamatest whoami"
)

with subtest("regression test for https://bugs.freedesktop.org/show_bug.cgi?id=77507"):
retcode, output = machine.execute("systemctl status testservice1.service")
assert retcode in [0, 3] # https://bugs.freedesktop.org/show_bug.cgi?id=77507
Expand Down