nixosTests.nscd: init, remove nixosTests.resolv #194916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
nixosTests.systemd is quite heavy, it requires a full graphical system, which is quite a big of a rebuild if the only thing you want to test is whether dynamic users work. This is now moved to an `nscd` test, which tests various NSS lookups, making extra sure that the nscd path is tested, not the fallback path (by hiding /etc/nsswitch.conf and /etc/hosts for getent). nixosTests.resolv is removed. It didn't check for reverse lookups, didn't catch nscd breaking halfway in between, and also had an ambiguous reverse lookup - 192.0.2.1 could either reverse lookup to host-ipv4.example.net, or host-dual.example.net.
flokli
force-pushed
the
nixos-test-nscd
branch
from
8fce77d to
1224368
Compare
github-actions
bot
added
the
8.has: module (update)
flokli
force-pushed
the
nixos-test-nscd
branch
from
09ad413 to
deea79f
Compare
ofborg
bot
added
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
flokli
force-pushed
the
nixos-test-nscd
branch
from
deea79f to
6eed70c
Compare
github-actions
bot
removed
the
8.has: module (update)
ofborg
bot
added
10.rebuild-linux: 0
This was referenced Oct 13, 2022
This shows that external nss module resolution is broken with unscd.
flokli
force-pushed
the
nixos-test-nscd
branch
from
6eed70c to
f08b8d6
Compare
picnoir
approved these changes
Oct 14, 2022
|
@GrahamcOfBorg test nscd |
|
Hmm, the Could it be related to [Edit]: it the getent call does not fail on a aarch64 host but does fail in a aarch64 VM running on that very same host. 🤔 |
picnoir
requested changes
Oct 14, 2022
|
@GrahamcOfBorg test nscd |
|
Apparently, the It's especially confusing because the other requests before, including those for dynamic user support do work, and because it also works fine when querying manually via |
|
Okay, it's actually flaky, not always failing. @GrahamcOfBorg test nscd |
|
Running this multiple times exposed it seems to be some flakyness in that lookup call, and it might not be limited to aarch64. |
This has shown to be flaky in the VM test, at least when running on the aarch64 ofborg builder(s). I assume it's some flakyness in systemd-networkd not being fully up, or at least not up to the point that it properly replies to the _gateway request. This part of the test is supposed to test external (non-glibc) nss module lookup for the host database works, which is already sufficiently covered in the previous checks (for *.localhost). Drop these redundant checks. We're not integration-testing networkd here.
|
@GrahamcOfBorg test nscd |
picnoir
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nixosTests.systemd is quite heavy, it requires a full graphical system, which is quite a big of a rebuild if the only thing you want to test is whether dynamic users work.
This is now moved to an
nscdtest, which tests various NSS lookups, making extra sure that the nscd path is tested, not the fallback path (by hiding /etc/nsswitch.conf and /etc/hosts for getent).nixosTests.resolv is removed. It didn't check for reverse lookups, didn't catch nscd breaking halfway in between, and also had an unabiguous reverse lookup - 192.0.2.1 could either reverse lookup to host-ipv4.example.net, or host-dual.example.net.
This also tests unscd, at least the parts that are known to work (see #193535).
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes