elixir_1_14: init at 1.14.0 #189355

shanesveller · 2022-09-01T22:02:51Z

Followed the example of #148619 since everything included still seems pertinent. However, some included packages do not build successfully on 1.14.0 yet, so I skipped the default (elixir) version change for purposes of this PR. Please let me know if the desired flow is instead to wait for such projects to become 1.14-compatible on their own.

Description of changes

https://elixir-lang.org/blog/2022/09/01/elixir-v1-14-0-released/
https://hexdocs.pm/elixir/1.14.0/changelog.html

Things done

Extras:

~~Default elixir version 1.13 -> 1.14~~
Removed unsupported 1.9 per https://hexdocs.pm/elixir/1.14.0/compatibility-and-deprecations.html

Defaults:

DianaOlympos · 2022-09-02T18:41:36Z

Which packages break with 1.14?

shanesveller · 2022-09-02T19:03:23Z

Which packages break with 1.14?

Sure, sorry for not including that info in the top post.

With this additional change:

diff --git a/pkgs/development/beam-modules/default.nix b/pkgs/development/beam-modules/default.nix
index 068e1da3313..66300e6bb2c 100644
--- a/pkgs/development/beam-modules/default.nix
+++ b/pkgs/development/beam-modules/default.nix
@@ -42,7 +42,7 @@ let
       elvis-erlang = callPackage ./elvis-erlang { };
 
       # BEAM-based languages.
-      elixir = elixir_1_13;
+      elixir = elixir_1_14;
 
       elixir_1_14 = lib'.callElixir ../interpreters/elixir/1.14.nix {
         inherit erlang;

I see compiler failures in prometheus_ex Hex package like so:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/0bcxv9k5qyfib5r8jh4shkc250laj5ar-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
@nix { "action": "setPhase", "phase": "buildPhase" }
building
warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8. Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell)
�[33mwarning: �[0muse Mix.Config is deprecated. Use the Config module instead
  config/config.exs:3

Compiling 19 files (.ex)

== Compilation error in file lib/prometheus/buckets.ex ==
** (UndefinedFunctionError) function Kernel.Utils.defdelegate/2 is undefined or private. Did you mean:

      * defdelegate_all/3
      * defdelegate_each/2

    (elixir 1.14.0) Kernel.Utils.defdelegate({:new, [line: 18], [{:arg, [line: 18], nil}]}, [])
    lib/prometheus/buckets.ex:18: (module)

And this fails the build for pleroma based on nixpkgs-review rev HEAD on x86_64-linux.

DianaOlympos · 2022-09-03T08:20:32Z

Thanks! Will have a look

That make me think we also need to fix the UTF8 problem, i keep having it.

mveytsman · 2022-09-04T16:21:39Z

FWIW plemora is depending on their own fork of prometheus_ex. The mainline repo compiles fine in Elixir 1.14.0.

I tried pinging someone who I think is a maintainer of the fork here: deadtrickster/prometheus.ex#48

bhankas · 2022-09-04T16:23:32Z

Can we just patch it to use mainline until upstream fixes it?

…

On Sun, 4 Sep, 2022, 21:51 Max Veytsman, ***@***.***> wrote: FWIW plemora is depending on their own fork <https://git.pleroma.social/pleroma/elixir-libraries/prometheus.ex/> of prometheus_ex. The mainline repo compiles fine in Elixir 1.14.0. I tried pinging someone what I think is a maintainer of the fork here: deadtrickster/prometheus.ex#48 <deadtrickster/prometheus.ex#48> — Reply to this email directly, view it on GitHub <#189355 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFZBOULX7AIDI4QAYPCHPLLV4TEB5ANCNFSM6AAAAAAQCYENSE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

SuperSandro2000 · 2022-09-04T17:04:26Z

pkgs/development/interpreters/elixir/1.14.nix

+# How to obtain `sha256`:
+# nix-prefetch-url --unpack https://github.com/elixir-lang/elixir/archive/v${version}.tar.gz


Suggested change

# How to obtain `sha256`:

# nix-prefetch-url --unpack https://github.com/elixir-lang/elixir/archive/v${version}.tar.gz

This is already in the contributing guide

Sorry, this was added by me a while ago.
I do not often contribute and this way it was easier for me (lower the barrier).

So please remove.

PS: There are probably more of this comments across the code base from me - should I remove them all?

Thanks for the review! Removed in the version committed as b73e0e9

PS: There are probably more of this comments across the code base from me - should I remove them all?

If the download link is not obvious then we can keep it but for github downloads at least we do not require them.

Ok. Thanks Sandro. I'll remove theme step by step in the places where I left theme.

cw789 · 2022-09-05T07:06:02Z

That make me think we also need to fix the UTF8 problem, i keep having it.

Isn't setting LANG & LC_TYPE to C.UTF-8 enough anymore?
→ https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/elixir/generic-builder.nix#L35-L36

https://elixir-lang.org/blog/2022/09/01/elixir-v1-14-0-released/ https://hexdocs.pm/elixir/1.14.0/changelog.html

happysalada · 2022-09-05T20:56:42Z

Nice to see you around here @shanesveller (I enjoyed quite enjoyed your blog when I was doing elixir)! Thank you for the contribution!

I think this is fine to merge to make the update available to everyone.

Regarding the UTF8 problem, I've never found how to fix it with nix as well. We are doing exactly what you pointed @cw789 but it seems it's not enough.
However I don't think the compilation error is a UTF8 problem here, it looks like the dependency is using an old alias for a function (defdelegate) and it should be a matter of updating the dependency. Hopefully the maintainer answers and we update the main elixir version in nixpkgs.

(let me know of course if you disagree).

DianaOlympos · 2022-09-05T21:29:10Z

Nah iirc there was a glibc patch a few years ago that broke it all and we need to patch it a bit. I have something somewhere. I never had time to dive in.

datafoo · 2022-09-12T12:00:09Z

Thank you for the work. I have a question/suggestion.

If this contribution had been split into 2 commits and 2 pull requests such as:

elixir_1_14: init at 1.14.0
elixir_1_9: remove following end of support

Would that have allowed to backport the first commit/PR to release-22.05?

happysalada · 2022-09-12T22:38:55Z

it would have indeed made the backport easier, we can think about that for next time! Thank you for your input on this.

github-actions bot added the 6.topic: erlang label Sep 1, 2022

ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Sep 1, 2022

cw789 mentioned this pull request Sep 2, 2022

elixir: 1.13.4 -> 1.14.0 #189462

Closed

DianaOlympos approved these changes Sep 2, 2022

View reviewed changes

bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 2, 2022

SuperSandro2000 reviewed Sep 4, 2022

View reviewed changes

elixir_1_14: init

b73e0e9

https://elixir-lang.org/blog/2022/09/01/elixir-v1-14-0-released/ https://hexdocs.pm/elixir/1.14.0/changelog.html

bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 5, 2022

happysalada merged commit 51d2625 into NixOS:master Sep 5, 2022

shanesveller deleted the shanesveller/package-elixir-1.14.0 branch September 8, 2022 13:03

datafoo mentioned this pull request Sep 12, 2022

elixir_1_14: init at 1.14.0 #190928

Merged

13 tasks

cw789 mentioned this pull request Sep 21, 2022

erlang: 25.0.3 -> 25.1 #192234

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

elixir_1_14: init at 1.14.0 #189355

elixir_1_14: init at 1.14.0 #189355

shanesveller commented Sep 1, 2022 •

edited

Loading

DianaOlympos commented Sep 2, 2022

shanesveller commented Sep 2, 2022

DianaOlympos commented Sep 3, 2022

mveytsman commented Sep 4, 2022 •

edited

Loading

bhankas commented Sep 4, 2022 via email

SuperSandro2000 Sep 4, 2022

cw789 Sep 5, 2022

cw789 Sep 5, 2022

shanesveller Sep 5, 2022

SuperSandro2000 Sep 6, 2022

cw789 Sep 6, 2022

cw789 commented Sep 5, 2022

happysalada commented Sep 5, 2022

DianaOlympos commented Sep 5, 2022

datafoo commented Sep 12, 2022 •

edited

Loading

happysalada commented Sep 12, 2022

		# How to obtain `sha256`:
		# nix-prefetch-url --unpack https://github.com/elixir-lang/elixir/archive/v${version}.tar.gz

elixir_1_14: init at 1.14.0 #189355

elixir_1_14: init at 1.14.0 #189355

Conversation

shanesveller commented Sep 1, 2022 • edited Loading

Description of changes

Things done

DianaOlympos commented Sep 2, 2022

shanesveller commented Sep 2, 2022

DianaOlympos commented Sep 3, 2022

mveytsman commented Sep 4, 2022 • edited Loading

bhankas commented Sep 4, 2022 via email

SuperSandro2000 Sep 4, 2022

Choose a reason for hiding this comment

cw789 Sep 5, 2022

Choose a reason for hiding this comment

cw789 Sep 5, 2022

Choose a reason for hiding this comment

shanesveller Sep 5, 2022

Choose a reason for hiding this comment

SuperSandro2000 Sep 6, 2022

Choose a reason for hiding this comment

cw789 Sep 6, 2022

Choose a reason for hiding this comment

cw789 commented Sep 5, 2022

happysalada commented Sep 5, 2022

DianaOlympos commented Sep 5, 2022

datafoo commented Sep 12, 2022 • edited Loading

happysalada commented Sep 12, 2022

shanesveller commented Sep 1, 2022 •

edited

Loading

mveytsman commented Sep 4, 2022 •

edited

Loading

datafoo commented Sep 12, 2022 •

edited

Loading