Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir_1_13: init at 1.13.0 #148619

Merged
merged 1 commit into from
Dec 6, 2021
Merged

elixir_1_13: init at 1.13.0 #148619

merged 1 commit into from
Dec 6, 2021

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Dec 4, 2021

Motivation for this change

Elixir 1.13 release (https://hexdocs.pm/elixir/1.13.0/changelog.html)

Things done

Set elixir_1_13 as default elixir version.
Removed elixir_1_8 elixir_1_7 (https://hexdocs.pm/elixir/compatibility-and-deprecations.html)

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@cw789
Copy link
Contributor Author

cw789 commented Dec 4, 2021

Quick preparation of bringing the new Elixir 1.13 to Nixpkgs.
I think I haven't forgotten anything.

@happysalada
Copy link
Contributor

@NixOS/beam might be interested in this change.
This looks good to me personally.
@turion just tagging you since last time we had some trouble with some elixir version upgrade for rabbitmq.

@cw789 thank you for this!

@happysalada
Copy link
Contributor

Since there is no feedback after the weekend and no particular request to delay, I'm going to go ahead and merge.
Happy to take care of any objections after the fact if there are any.

@happysalada happysalada merged commit bc5d683 into NixOS:master Dec 6, 2021
@cw789 cw789 deleted the elixir_update branch December 6, 2021 16:40
@yu-re-ka
Copy link
Contributor

yu-re-ka commented Dec 6, 2021

This broke pleroma

@happysalada
Copy link
Contributor

ah, sorry about that.
upstream seems to be using 1.9 https://git.pleroma.social/pleroma/pleroma/-/blob/develop/elixir_buildpack.config
perhaps it would be better to fix the elixir version for pleroma ?
I'm leaning towards sensitive packages fixing the version to not delay upgrades.

@yu-re-ka
Copy link
Contributor

yu-re-ka commented Dec 6, 2021

I don't think there is an easy way to pin pleroma to a different elixir version unfortunately. Also elixir 1.12 works fine for pleroma.

@happysalada
Copy link
Contributor

Somebody added fixing elixir version for mixRelease, but it's not there yet for buildMix. I can probably have a look this weekend if it's okay. Just to be sure I'm talking about adding the override possibility to buildMix then fixing the elixir version to 1.12

@yu-re-ka
Copy link
Contributor

yu-re-ka commented Dec 6, 2021

Pleroma also uses other packages from beamPackages, although I don't know if they depend on elixir. I think we should add a way to get a custom version of beamPackages with a different elixir version. Otherwise we will just have to add more overrides to change each package's elixir version, or we will pull two elixir versions in the closure.

@yu-re-ka
Copy link
Contributor

yu-re-ka commented Dec 7, 2021

#149169

@shanesveller shanesveller mentioned this pull request Sep 1, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants