Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elementary-planner: hardcoded themes & vala 0.56 fixes #164555

Merged
merged 3 commits into from
Mar 19, 2022
Merged

elementary-planner: hardcoded themes & vala 0.56 fixes #164555

merged 3 commits into from
Mar 19, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Mar 17, 2022 •
edited
Loading

Description of changes
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bobby285271 bobby285271 changed the title elementary-planner: various fixes elementary-planner: hardcoded themes & vala 0.56 fixes Mar 17, 2022
@bobby285271
Copy link
Member Author

bobby285271 commented Mar 17, 2022 •
edited
Loading

@ofborg eval

@jtojnar jtojnar mentioned this pull request Mar 17, 2022
Merged
13 tasks
@ofborg ofborg bot requested review from dtzWill and davidak March 17, 2022 09:16
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 17, 2022
bobby285271 and others added 3 commits March 18, 2022 09:54
@bobby285271
elementary-planner: fix wrong hardcoded GTK theme name
019e6fd 
The theme name is updated in elementary OS 6.
@bobby285271 @jtojnar
elementary-planner: pick up hardcoded icon theme
76ab64a 
With NixOS#163623, we need to handle
the hardcoded icon theme ourselves.

Co-authored-by: Jan Tojnar <[email protected]>
@bobby285271
elementary-planner: fix build with vala 0.56
4d201e7
@bobby285271
Copy link
Member Author

Result of nixpkgs-review pr 164555 run on x86_64-linux 1

1 package built:
  • elementary-planner

@bobby285271 bobby285271 merged commit 76f5860 into NixOS:master Mar 19, 2022
@bobby285271 bobby285271 deleted the elementary-planner branch March 19, 2022 01:44
@bobby285271 bobby285271 mentioned this pull request Mar 31, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@dtzWill dtzWill Awaiting requested review from dtzWill

@davidak davidak Awaiting requested review from davidak

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobby285271 @jtojnar