Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pantheon: prepare for vala 0.56 #164085

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Pantheon: prepare for vala 0.56 #164085

merged 2 commits into from
Mar 14, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Mar 14, 2022 •
edited
Loading

Description of changes

So they won't fail to build when vala 0.56 becomes default (which will likely happen in the GNOME 42 pull request).

Previous "prepare for xxx" PR: #154837

Things done
  • On x86_64-linux, use Vala 0.55.91 to build Pantheon packages:
    • Built nixosTests.pantheon
    • Built pantheon.appcenter pantheon.sideload
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label Mar 14, 2022
@ofborg ofborg bot requested review from ethancedwards8 and davidak March 14, 2022 09:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 14, 2022
davidak
davidak approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@bobby285271 bobby285271 mentioned this pull request Mar 14, 2022
Merged
@bobby285271
Copy link
Member Author

@ofborg test pantheon

@ofborg ofborg bot requested a review from davidak March 14, 2022 12:14
@bobby285271
Copy link
Member Author

Result of nixpkgs-review pr 164085 run on x86_64-linux 1

2 packages built:
  • pantheon.elementary-mail
  • pantheon.elementary-photos

@bobby285271 bobby285271 marked this pull request as ready for review March 14, 2022 14:49
@bobby285271
Copy link
Member Author

bobby285271 commented Mar 14, 2022 •
edited
Loading

I went through list of issues opened by decathorpe and I think this should ready to go.

For other apps the pantheon team maintain:

Update: Addressed in #164837 and #164555

@bobby285271 bobby285271 merged commit 45289e1 into NixOS:master Mar 14, 2022
@bobby285271 bobby285271 deleted the pantheon branch March 14, 2022 14:56
@bobby285271 bobby285271 mentioned this pull request Mar 31, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

@davidak davidak Awaiting requested review from davidak

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobby285271 @davidak