go_1_18: init at go1.18beta1

[c00w]

The go 1.18 beta1 is out. It appears to be building fully (and
suprisingly quickly too - :) ).

I trimmed a couple patches which referenced golang issues which had been
closed.

Motivation for this change

One of the important things to do for go betas, is to actually use them to find bugs. By landing this early, this allows nixos users (like myself), to easily update their packages to use go1.18beta1. It also means that when go1.18 is released, we can just do a version bump.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[zowoq]

--- pkgs/development/compilers/go/1.17.nix
+++ pkgs/development/compilers/go/1.18.nix
@@ -54,11 +54,11 @@
 
 stdenv.mkDerivation rec {
   pname = "go";
-  version = "1.17.6";
+  version = "1.18beta1";
 
   src = fetchurl {
-    url = "https://dl.google.com/go/go${version}.src.tar.gz";
-    sha256 = "sha256-TcG78/9h8MH/Kxk1Xm2IFRpwEmJopHx2FHdobvlHSMg=";
+    url = "https://go.dev/dl/go${version}.src.tar.gz";
+    sha256 = "sha256-QYwCjbFGmctbLUkHrTpBnXn3ibMZFu+HZIZ+SnjmU6E=";
   };
 
   # perl is used for testing go vet
@@ -166,17 +166,10 @@
     ./ssl-cert-file-1.16.patch
     ./remove-test-pie-1.15.patch
     ./creds-test.patch
-    ./go-1.9-skip-flaky-19608.patch
-    ./go-1.9-skip-flaky-20072.patch
     ./skip-external-network-tests-1.16.patch
     ./skip-nohup-tests.patch
     ./skip-cgo-tests-1.15.patch
     ./go_no_vendor_checks-1.16.patch
-  ] ++ [
-    # breaks under load: https://github.com/golang/go/issues/25628
-    (if stdenv.isAarch32
-    then ./skip-test-extra-files-on-aarch32-1.14.patch
-    else ./skip-test-extra-files-on-386-1.14.patch)
   ];
 
   postPatch = ''

[c00w]

@zowoq - Sorry don't quite know what you mean by that comment - are you saying we should delete the go1.17 file? Or are you just summarizing the 1.17 to 1.18 delta?

[zowoq]

Yes, just summarizing the delta.