go: Fix the build in non-root sandboxes

[thufschmitt]

Motivation for this change

Workaround for golang/go#42525

(Also related to NixOS/nix#3245)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[SuperSandro2000]

Maybe we want to throw that on staging?

[zowoq]

Is this only an issue with go_1_16 or does it need to be applied to go_1_17 as well?

[thufschmitt]

Is this only an issue with go_1_16 or does it need to be applied to go_1_17 as well?

I actually didn’t try it with other go versions, but I guess it would need to be ported here as well since the upstream bug is still open

[hhoeflin]

Will this be merged? One of my builds is also affected by this. Thanks

[SuperSandro2000]

The same needs to be applied to go 1.17 and we should target staging because this change is not very important and does not need to trigger so many rebuilds on master.

[gurgl]

Just chiming in to say im affacted by this too. Running nix on ubuntu 20.04, if that matters.

[zowoq]

@ofborg build go_1_17

[zowoq]

I added the patch to the go 1.18 PR in #157650 so it doesn't get overlooked.

I'll rebase this after the patch lands in staging and merge.

[zowoq]

@jonringer Can I squeeze this into the new staging-next?

[jonringer]

I just started this, 5 mins before you posted :(

[zowoq]

I was waiting for the merge action to push the patch from master to staging when I saw you do it manually. 😆

This waited a couple of months until I picked it up, it can wait until the next cycle.