Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-21.11] nscd service: fix ordering and start automatically #154620

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-21.11, triggered by a label in #154320.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

During working on #150837 I discovered that `google-oslogin` test
started failing, and so did some of my development machines. Turns out
it was because nscd doesn't start by default; rather it's wanted by
NSS lookup targets, which are not always fired up.

To quote from section on systemd.special(7) on `nss-user-lookup.target`:

> All services which provide parts of the user/group database should be
> ordered before this target, and pull it in.

Following this advice and comparing our unit to official `sssd.service`
unit (which is a similar service), we now pull NSS lookup targets from
the service, while starting it with `multi-user.target`.

(cherry picked from commit b451eca)
@flokli
Copy link
Contributor

flokli commented Jan 11, 2022

Just as a precaution, let's have the original PR sink for two weeks or so, just in case there's any regressions/weird corner cases we forgot about.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 11, 2022
@dasJ dasJ mentioned this pull request Jan 27, 2022
13 tasks
@dasJ
Copy link
Member

dasJ commented Jan 30, 2022

@flokli Is the ripening time enough now? :)

@flokli
Copy link
Contributor

flokli commented Jan 30, 2022 via email

@dasJ dasJ merged commit f045ae5 into release-21.11 Jan 30, 2022
@dasJ dasJ deleted the backport-154320-to-release-21.11 branch January 30, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants