-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nscd service: fix ordering and start automatically #154320
Conversation
During working on NixOS#150837 I discovered that `google-oslogin` test started failing, and so did some of my development machines. Turns out it was because nscd doesn't start by default; rather it's wanted by NSS lookup targets, which are not always fired up. To quote from section on systemd.special(7) on `nss-user-lookup.target`: > All services which provide parts of the user/group database should be > ordered before this target, and pull it in. Following this advice and comparing our unit to official `sssd.service` unit (which is a similar service), we now pull NSS lookup targets from the service, while starting it with `multi-user.target`.
Thanks for this. This is definitely correct and the previous behaviour was not. I also recently noticed nscd started way too late. |
It might actually make sense to start nscd even earlier than multi-user.target but for now this is fine |
If I understand this correctly, the idea is instead to make services which depend on name resolution run after NSS lookup targets are reached, so |
Let's get this in. It's better than it was for sure, if we can improve further, we still can ;-) |
Successfully created backport PR #154620 for |
During working on #150837 I discovered that
google-oslogin
teststarted failing, and so did some of my development machines. Turns out
it was because nscd doesn't start by default; rather it's wanted by
NSS lookup targets, which are not always fired up.
To quote from systemd.special(7) section on
nss-user-lookup.target
:Following this advice and comparing our unit to official
sssd.service
unit (which is a similar service), we now pull NSS lookup targets from
the service, while starting it with
multi-user.target
.Motivation for this change
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesTested by using it together with new GCE configuration from #150837, and with
google-oslogin
test.