Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/archisteamfarm: init; ASF-ui: init; ArchiSteamFarm: 5.1.5.3 -> 5.2.0.10 & fix build on aarch-64 #148541

Merged
merged 8 commits into from
Jan 10, 2022
Merged

nixos/archisteamfarm: init; ASF-ui: init; ArchiSteamFarm: 5.1.5.3 -> 5.2.0.10 & fix build on aarch-64 #148541

merged 8 commits into from
Jan 10, 2022

Conversation

legendofmiracles
Copy link
Contributor

@legendofmiracles legendofmiracles commented Dec 4, 2021 •
edited
Loading

  • nixos/archisteamfarm: init
  • ASF-ui: init
  • ArchiSteamFarm: 5.1.5.3 -> 5.2.0.9
Motivation for this change

Adds a nixos module, the asf web-ui and updates archi-steam-farm to the latest version.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 4, 2021
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 4, 2021
@legendofmiracles legendofmiracles force-pushed the final-asf branch 2 times, most recently from 9797f9f to e10bfd7 Compare December 4, 2021 03:13
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Dec 4, 2021
@legendofmiracles legendofmiracles force-pushed the final-asf branch 2 times, most recently from 0dde834 to b6a9b79 Compare December 4, 2021 03:37
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/421

@legendofmiracles
Copy link
Contributor Author

@SuperSandro2000 poke :)

@legendofmiracles legendofmiracles mentioned this pull request Dec 24, 2021
Closed
@legendofmiracles legendofmiracles mentioned this pull request Dec 28, 2021
Merged
13 tasks
@legendofmiracles legendofmiracles mentioned this pull request Dec 29, 2021
Closed
13 tasks
@prusnak prusnak mentioned this pull request Dec 30, 2021
Merged
13 tasks
@ofborg ofborg bot requested a review from SuperSandro2000 December 31, 2021 00:16
IvarWithoutBones
IvarWithoutBones approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say much about the web ui addition, but the main package and nixos module LGTM 👍

@legendofmiracles legendofmiracles force-pushed the final-asf branch 2 times, most recently from d9ca689 to 6cdb260 Compare January 2, 2022 23:24
@legendofmiracles
Copy link
Contributor Author

Resolved merge conflict.
If nothing more is wrong, I'll go ahead and merge this within the next couple of days. I've been running this branch for a month now - on both aarch64 and x86_64, without any issues.

@legendofmiracles legendofmiracles force-pushed the final-asf branch 2 times, most recently from 4ae0de6 to 3eae672 Compare January 10, 2022 02:21
@legendofmiracles legendofmiracles merged commit d9b2a76 into NixOS:master Jan 10, 2022
@legendofmiracles legendofmiracles deleted the final-asf branch January 10, 2022 02:45
@legendofmiracles legendofmiracles mentioned this pull request Jun 3, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustArchi JustArchi JustArchi left review comments

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@aanderse aanderse aanderse approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendofmiracles @nixos-discourse @JustArchi @SuperSandro2000 @aanderse @IvarWithoutBones