buildDotnetPackage/fetchNuGet: use pname instead of name and baseName

[Stunkymonkey]

Motivation for this change

follow up of #144949

for buildDotnetPackage the variable baseName was renamed to pname.
i found, the naming of fetchNuGet use name and version. therefore i decided to rename it to pname & version.

sadly this PR turned out to be larger, then expected

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[SuperSandro2000]

At some point we should cleanup all those extra fetchNugetDeps functions.

[Stunkymonkey]

can this be merged to master, or should i rebase it to staging?

[prusnak]

can this be merged to master,

Let's aim for master. There are not a lot of rebuilds (11-100). Please rebase and resolve the conflicts.

@IvarWithoutBones can you please have a look? what do you think about this change?

[Stunkymonkey]

I removed the two commits about wasabibackend&github-runner and will adress the improvments in a separate PR, because this PR has a long diff.

[IvarWithoutBones]

LGTM, i think this makes buildDotnetPackage derivations look a lot cleaner, I just have 1 (kind of unrelated) suggestion :)

Thanks for the ping btw! I appreciate it.

[IvarWithoutBones]

Thanks!