Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyarrow: fix darwin build for when a build flag is false #148262

Merged
merged 1 commit into from
Dec 2, 2021
Merged

python3Packages.pyarrow: fix darwin build for when a build flag is false #148262

merged 1 commit into from
Dec 2, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 2, 2021

Motivation for this change

Fix regression from #147718

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@veprbl
python3Packages.pyarrow: fix darwin build for when a build flag is false
e569082 
nix-repl> with import <nixpkgs> {}; stdenv.mkDerivation { name="test"; true = true; false = false; }
«derivation /nix/store/2xk4hhfnaqymwq0iw9hxi5a34a8dbywz-test.drv»

nix show-derivation /nix/store/2xk4hhfnaqymwq0iw9hxi5a34a8dbywz-test.drv | grep -E '(true|false)'
      "false": "",
      "true": "1"

  File "setup.py", line 77, in strtobool
    raise ValueError("invalid truth value %r" % (val,))
ValueError: invalid truth value ''
@veprbl
Copy link
Member Author

veprbl commented Dec 2, 2021

@GrahamcOfBorg build python38Packages.pyarrow python39Packages.pyarrow

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 2, 2021
@ofborg ofborg bot requested a review from cpcloud December 2, 2021 11:01
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 2, 2021
@Mic92 Mic92 merged commit f515c92 into NixOS:master Dec 2, 2021
@github-actions github-actions bot mentioned this pull request Dec 2, 2021
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Successfully created backport PR #148292 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veprbl @cpcloud @Mic92