Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyarrow: enable dataset and flight modules #147718

Merged
merged 2 commits into from
Nov 30, 2021
Merged

python3Packages.pyarrow: enable dataset and flight modules #147718

merged 2 commits into from
Nov 30, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Nov 28, 2021

  • python3Packages.pyarrow: enable dataset module
  • python3Packages.pyarrow: add cpcloud as maintainer
  • python3Packages.pyarrow: enable flight module
Motivation for this change

Enable the _dataset and _flight modules in pyarrow

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@cpcloud cpcloud requested a review from veprbl November 28, 2021 14:32
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 28, 2021
@cpcloud cpcloud changed the title python3Packages: enable dataset and flight modules python3Packages.pyarrow: enable dataset and flight modules Nov 28, 2021
@veprbl
Copy link
Member

veprbl commented Nov 28, 2021

@GrahamcOfBorg build python38Packages.pyarrow python39Packages.pyarrow

@cpcloud cpcloud force-pushed the pyarrow-enable-extra-modules branch from 7141a89 to be28f63 Compare November 29, 2021 17:41
@cpcloud cpcloud requested a review from veprbl November 29, 2021 17:42
@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 29, 2021

@veprbl Thanks, done.

@veprbl
Copy link
Member

veprbl commented Nov 30, 2021

@cpcloud Could you please squash the last three comments.

@cpcloud cpcloud force-pushed the pyarrow-enable-extra-modules branch from be28f63 to da8dfd5 Compare November 30, 2021 13:30
@cpcloud cpcloud requested a review from veprbl November 30, 2021 13:30
@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 30, 2021

@veprbl Done. Thanks for the review.

@veprbl veprbl merged commit 365b448 into NixOS:master Nov 30, 2021
@github-actions github-actions bot mentioned this pull request Nov 30, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #148025 for release-21.11.

@github-actions
Copy link
Contributor

The process '/usr/bin/git' failed with exit code 1

@veprbl veprbl mentioned this pull request Dec 2, 2021
Merged
13 tasks
@cpcloud cpcloud deleted the pyarrow-enable-extra-modules branch May 11, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @veprbl