Stabilise fetchTree #10068
Stabilise fetchTree #10068
Conversation
Add two new features: - `fetch-tree-git` to enable the `git` fetcher for `fetchTree` - `fetch-tree-urls` to enable the URL-like syntax for `fetchTree` `fetch-tree` is kept as a backwards-compatibility alias for the two new features.
Run the fetchTree-file test without the experimental feature to make sure that it works properly
github-actions
bot
added
with-tests
Make sure that enabling `fetch-tree` also enables `fetch-tree-git` and `fetch-tree-urls`.
| The core of `fetchTree` is now stable. | ||
| This includes | ||
| - the `fetchTree` function itself | ||
| - all the existing fetchers, except `git` (still unstable because of some reproducibility concerns) |
There was a problem hiding this comment.
git is the only one we've actually improved during this time.
gitlab has known problems (wrong field names, wrong url syntax)
mercurial and all the other fetchers we haven't talked about are under-used and should be assumed to have repro problems
github is still git archive-based, not tree-based.
- users who switch between
gitandgithubfetchers will be surprised to see their hash changed gitcan't be reliably be used as a fallback implementation forgithubfetching because ofexport-subst(export-ignoremight work)
tarball is probably the only fetcher without severe issues and also been reviewed properly. All the other ones should remain feature gated.
|
Discussed during the Nix maintainers meeting on 2024-02-26.
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-02-28-nix-team-meeting-129/40499/1 |
Motivation
Stabilise the core of
fetchTree.This includes:
fetchTreefunction itselfgit(still unstable because of some reproducibility concerns)Context
Agreed-upon to be stabilised after the 2.20. About time we do it now :)
This introduces two new experimental features (yay!) for the git fetcher and flakeref-style urls which are still experimental.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.