Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run checks in automatic update PRs #357

Closed
fricklerhandwerk opened this issue Nov 14, 2024 · 0 comments · Fixed by #360
Closed

Run checks in automatic update PRs #357

fricklerhandwerk opened this issue Nov 14, 2024 · 0 comments · Fixed by #360

Comments

@fricklerhandwerk
Copy link
Collaborator

Technically the checks did run, the run is this one, but the run isn't linked to this PR so the checks aren't visible in the UI.

This happens for two reasons:

  1. The checks are triggered by this action, which is a workflow_dispatch and workflow dispatches are considered a "manual run", so they don't update PR information. Only ["pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_target", "push"] actions can link and update an action run to a PR.
  2. The reason checks aren't triggered by default is this issue. The tl;dr is that GitHub doesn't allow (most) actions to create further actions when using the default GITHUB_TOKEN. There are various workarounds we can use, I think going with the last one (GH App token) makes the most sense in our case.

Originally posted by @Erethon in #329 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants