Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.2.1 #42

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Release v1.2.1 #42

merged 4 commits into from
Mar 11, 2024

Conversation

msimerson
Copy link
Collaborator

@msimerson msimerson commented Mar 11, 2024 •
edited
Loading

@msimerson
feat(A,MX,AAAA,CAA,IPSECKEY): added getCanonical
3f2af6e 
- fix(nsec3param): fixed setHash fname typo
- feat(SVCB,HTTPS): add record support (#29)
- feat(OPENGPGPKEY): improved bindline parser, added test
- feat(throwHelp): far more useful error messages (#41)
- feat(NS): add nsdname as alias for dname
- feat(PTR): added ptrdname as alias for dname
- feat(TXT): added rdata as alias for data
@msimerson
lint
a5cf0f7
@msimerson msimerson marked this pull request as ready for review March 11, 2024 06:22
@coveralls
Copy link

coveralls commented Mar 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8228689560

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 91.692%
Totals Coverage Status
Change from base Build 8209532018: 0.3%
Covered Lines: 3828
Relevant Lines: 4101
💛 - Coveralls

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 11, 2024
View reviewed changes
rr/openpgpkey.js
Comment on lines +33 to +35
const [ignore, owner, ttl, c, type, publickey] = obj.bindline.match(
/^([\S]+)\s+(\d+)\s+(\w+)\s+(\w+)\s+([\W\w]*)$/,
)

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '\t' and with many repetitions of '\t'.
@msimerson msimerson merged commit 414ace2 into main Mar 11, 2024
12 of 13 checks passed
@msimerson msimerson deleted the release-1.2.1 branch March 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msimerson @coveralls