Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(throwHelp): far more useful error messages #41

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

msimerson
Copy link
Collaborator

@msimerson msimerson commented Mar 8, 2024

Before

> new RR.A({ owner: 'matt.simerson.', type: 'A', ttl: 3600 })
Uncaught Error: A: address is required
    at A.setAddress (file:///Users/matt/git/nictool/dns-resource-record/rr/a.js:12:21)
    at new RR (file:///Users/matt/git/nictool/dns-resource-record/rr.js:25:19)
    at new A (file:///Users/matt/git/nictool/dns-resource-record/rr/a.js:7:5)

After

> new RR.A({ owner: 'matt.simerson.', type: 'A', ttl: 3600 })
Uncaught Error: A: address is required

Example A:
{
  'owner' => 'test.example.com.',
  'type' => 'A',
  'ttl' => 3600,
  'class' => 'IN',
  'address' => '192.0.2.127'
}

see RFC 1035

    at A.throwHelp (file:///Users/matt/git/nictool/dns-resource-record/rr.js:133:11)
    at A.setAddress (file:///Users/matt/git/nictool/dns-resource-record/rr/a.js:12:20)
    at new RR (file:///Users/matt/git/nictool/dns-resource-record/rr.js:27:19)
    at new A (file:///Users/matt/git/nictool/dns-resource-record/rr/a.js:7:5)

@NicTool NicTool deleted a comment from coveralls Mar 8, 2024
@msimerson msimerson merged commit feb5654 into main Mar 8, 2024
13 checks passed
@msimerson msimerson deleted the throwHelp branch March 8, 2024 22:02
msimerson added a commit that referenced this pull request Mar 11, 2024
- fix(nsec3param): fixed setHash fname typo
- feat(SVCB,HTTPS): add record support (#29)
- feat(OPENGPGPKEY): improved bindline parser, added test
- feat(throwHelp): far more useful error messages (#41)
- feat(NS): add nsdname as alias for dname
- feat(PTR): added ptrdname as alias for dname
- feat(TXT): added rdata as alias for data
@msimerson msimerson mentioned this pull request Mar 11, 2024
msimerson added a commit that referenced this pull request Mar 11, 2024
* feat(A,MX,AAAA,CAA,IPSECKEY): added getCanonical
- fix(nsec3param): fixed setHash fname typo
- feat(SVCB,HTTPS): add record support (#29)
- feat(OPENGPGPKEY): improved bindline parser, added test
- feat(throwHelp): far more useful error messages (#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant