Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade docs to vuepress v2.0.0-rc and implement dark mode #3395

Merged
merged 4 commits into from
Jan 9, 2024
Merged

upgrade docs to vuepress v2.0.0-rc and implement dark mode #3395

merged 4 commits into from
Jan 9, 2024

Conversation

tilalx
Copy link
Contributor

@tilalx tilalx commented Dec 18, 2023

Design Overview Update

An updated design image has been incorporated to improve the visual representation of the project, now featuring Dark Mode support in the documentation. This enhancement not only aligns with contemporary aesthetic preferences but also offers an alternative viewing mode that is considerate of varying user needs and contexts. The revised design can be viewed here:

Updated Design

Environment Specifications

The project has been thoroughly tested with the following environment setup to ensure compatibility and stability:

  • Node.js version: 18
  • Yarn version: 4
  • vuepress: 2.0 rc

@tilalx tilalx changed the title upgrade to v2.0.0-rc and implement dark mode upgrade docs to vuepress v2.0.0-rc and implement dark mode Dec 19, 2023
@tilalx
Copy link
Contributor Author

tilalx commented Dec 21, 2023

Hi @jc21,

Could you please guide me on how to access the Jenkins logs for the failed build? Also, I am wondering if Node.js version 18 is available on the Jenkins server. If it is, could we possibly select it using nvm use 18 for the build process?

Thank you!

@tilalx tilalx mentioned this pull request Jan 2, 2024
docs/guide/README.md Outdated Show resolved Hide resolved
@jc21
Copy link
Member

jc21 commented Jan 8, 2024

@tilalx the node version used in CI for docs building is pretty much the latest, as it's using node:alpine docker image. At this time that version is v21.5.0

@jc21
Copy link
Member

jc21 commented Jan 8, 2024

Can you fix up the conflicts after rebasing and CI will try again.

@nginxproxymanagerci
Copy link

Docker Image for build 9 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3395

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21 jc21 merged commit 4028120 into NginxProxyManager:develop Jan 9, 2024
1 check passed
@jc21
Copy link
Member

jc21 commented Jan 9, 2024

The CI nodes have been updated to node 20. The preview documentation for the develop branch is available here:

https://develop.nginxproxymanager.com/

I noticed a few things with the menu:

  • Home is no longer a menu link
  • /guide path is in the menu
  • The menu headers are duplicated

can we fix those in a new PR?

Screenshot 2024-01-10 at 9 43 52 am

Screenshot 2024-01-10 at 9 45 35 am

@tilalx
Copy link
Contributor Author

tilalx commented Jan 10, 2024

Yes, we can open a new PR and fix this small bug.
#3445

image

@jc21
Copy link
Member

jc21 commented Jan 10, 2024

Awesome thanks

@tilalx
Copy link
Contributor Author

tilalx commented Jan 10, 2024

Thank you as well!

@onurmercury onurmercury mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants