-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode Support #707
Comments
This would be awesome! |
This comment has been minimized.
This comment has been minimized.
It looks like Tabler supports it: https://preview.tabler.io/layout-dark.html |
And it indeed looks sexy. I'm rewriting the UI with react for version 3, which which be much easier to integrate a dark mode. |
I've played a bit around with the SCSS and also implementing one without the tabler resources is not very difficult: https://gitlab.jonasled.de/jonasled/nginx-proxy-manager-dark/-/blob/master/frontend/scss/darkmode.scss |
Where can I change these files? |
Hello, how Can i implent the Dark Mode in my Proxy Manager Version 2.9.7? |
I created a Dark Mode theme VIA CSS which can be easily applied VIA the Stylish Extension. Stylish will allow you to toggle the theme quickly if you so choose. In addition it will allow for you to make easy/live modifications if you'd like to change the theme to your preferences. I have heavily commented my CSS to give you some understanding of the areas I've changed. You can find the Stylish theme that I created here: You can also create a custom CSS then mount it within the NGINX Proxy Manager docker container. This I would consider to be a little bit more of an advanced method, but this would mean no matter where NGINX Proxy manager was accessed from it would display the custom theme; Unlike with the Stylish extension, where the extension must be installed for the theme to be visible. I'm honestly surprised there is no option within the GUI to provide custom CSS. Or instructions on simply mounting a CSS file within the container. Please note that the CSS for the Stylish theme I provided will only modify portions of the CSS I wanted to change. It is not a complete CSS for NGINX Proxy Manager and I would not recommend mounting it in your docker container. NGINX Also allows for sub filters to be used when passing a webpage or server through it, which in turn can cause CSS to be loaded this way as well. If you were to pass NGINX Manager through itself, and apply a sub filter this would allow for modification of the CSS as well. There are A LOT of ways themes/custom CSS could be implemented into this application and I would HIGHLY suggest it. Even if it's just VIA the ability to apply your own custom CSS overtop of the original CSS. User's will eventually create themes and there will be an immense variety of options. Until the develop opts to support this functionality though, I doubt we will see many themes developed for the application. It's obvious that this is a sought after feature though. Within 24 hrs of me submitting my theme, there was thirteen separate user's whom had installed it. In such a short period of time, that screams to me others are deeply interested in a Dark Mode option. |
Installing browser plugins is not an option for me. |
I would love to see theme-park.dev support on nginx-proxy-manager, though that seems to imply requiring linuxserver.io builds |
There are alternative suggestions in my post. Though, the most non-technical method would be to use an Extension.
|
Could you explain, how i can apply the CSS in Nginx? Do i need the Advanced Tab for this? |
Here's my attempt to create dark theme CSS, it's very chatty but should cover almost everything |
My Gravatar didn't like it, went all gray. Other than that it looks real nice! |
How do I use this? |
I just put it in Stylus since Stylish had some shady things going on that I don't care enough to remember. |
Interesting. Mine seems to show fine. Just in case I've made it against the latest v2.9.15 (at the time of writing). So maybe check your version. But this is getting out of topic, so comment on a gist if you need any help |
Alright |
Is there a way to implement this custom.css via the Nginx Proxy Manager so every Device in the Network is affected? |
Yes, you can add the stylesheet on the server, if you place the file in |
can you explain that to me in a bit more detail? |
Hi @jonasled - would you be able to provide some specific instructions on where these files can be found? Myself, and I'm sure others, are likely running nginx proxy manager via a docker container, so access to some of these core files may not be available. Would I be correct in my (limited) understanding that we'd need to either:
I'm not sure what the best path forward here would be, but it sounds like many other people would like dark mode as well, so your help is appreciated! |
Changing the configuration of a running container dosn't work. You have to take the sourcecode and then place the dark.scss in frontend => scss. Afterwards you have to add Afterwards you have to build the container with the following script: echo 'Setting Version'
sed -i "s/0.0.0/${BUILD_VERSION}/" frontend/package.json
sed -i "s/0.0.0/${BUILD_VERSION}/" backend/package.json
echo 'Building Frontend ...'
bash scripts/frontend-build
echo 'Checking Syntax ...'
docker run --rm -v "$(pwd)/backend:/app" -v "$(pwd)/global:/app/global" -w /app node:latest sh -c "yarn install && yarn eslint . && rm -rf node_modules"
echo 'Docker Build ...'
docker build --pull --no-cache --compress -t "nginx-proxy-manager-dark:latest" -f docker/Dockerfile --build-arg TARGETPLATFORM=linux/amd64 --build-arg BUILDPLATFORM=linux/amd64 --build-arg BUILD_VERSION="${BUILD_VERSION}" --build-arg BUILD_COMMIT="${BUILD_COMMIT}" --build-arg BUILD_DATE="$(date '+%Y-%m-%d %T %Z')" . |
Thanks for your help with this. If I understood your instructions correctly, then the first step would be to clone the repository for the dark mode, which would be located here. From there, I executed both the frontend-build script and the docker run command you have listed. However, when running the final docker build command, I receive the following error:
For reference, I'm running this on a fresh install of Ubuntu Server 21.10. Any ideas what may be causing this? It is not an error I've encountered previously. Here is the full output:
|
Please make a dark mode standard. My eyes are bleeding. |
I use now the Dark Theme from theme-park.dev - looks really good 😎 |
Nice one @root9191. I am switching to these themes as well. For people using Stylus the cheeky way to use the theme is like this @import url("https://theme-park.dev/css/base/nginx-proxy-manager/organizr.css"); |
Is there any progress on this dark mode w/o the use of additional add-ons? |
I've added a script you can mount btw. |
@GilbN I'm having some troubles settings this up:
I'm doing that in the Nging Proxy Manager's docker-compose.yml, is that correct? In the volume entry do we have to point to the script itself or to the folder containing it? |
There's a bug in the script. Change And yes, point it to the file. And the name doesn't matter. |
When will the script be updated? - I see 'APP_FILEPATH' referenced serveral times throughout the script. Do I need to edit every single one and replace it with 'app/frontend'? |
The script has been updated. Did you you try it? |
Hi, |
Would be nice if they just added this functionality by default as pretty much everything else I use has a dark mode. |
Hi, Thank you! |
+1 from me as well |
Issue is now considered stale. If you want to keep it open, please comment 👍 |
👍 |
1 similar comment
👍🏻 |
Any news yet ? |
please add dark theme support |
Dark mode support please |
You can already get the dark theme:
in the same folder as your docker-compose.yml create a "theme" folder, and create this 98-themepark file inside it (literally copy and paste), edit line 45 if you want a different theme |
You can set dark mode also without bind mount:
It should look something like this (forward hostname nginx-proxy-manager is the name of my container):
Sources: |
I had to do a CTRL-SHIFT-R (=reload and ignore cache) in Google Chrome to make it go into effect, after noticing it would only work right away inside an incognito/inprivate tab. |
Duplicate of #4314 . |
RFE for Dark Mode Support
The text was updated successfully, but these errors were encountered: