Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/boolti 301 타인의 프로필 구현 #304

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Conversation

mangbaam
Copy link
Member

@mangbaam mangbaam commented Oct 6, 2024

Issue

작업 내용

  • [fix] 출연진 한 명일 때 노출 안 되는 이슈 해결
  • [feat] 프로필 구현
    • 내 프로필이면 편집할 수 있는 내 프로필로 이동
    • 타인의 프로필 이동
    • 불러올 수 없는 프로필의 경우 다이얼로그 표시 후 내보내기
  • [refactor] User 데이터 클래스를 sealed interface로 변경 후 My와 Others 하위 클래스로 분리
    • 동일한 모델을 사용하려고 했는데 타인의 정보는 id, email 등 불필요한 정보를 내려주지 않아서 구분함
default.mp4

@mangbaam mangbaam requested a review from HamBP October 6, 2024 12:59
@mangbaam mangbaam self-assigned this Oct 6, 2024
@mangbaam mangbaam changed the title Feature/boolti 301 출연자 목록 및 타인의 프로필 구현 Feature/boolti 301 타인의 프로필 구현 Oct 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

Test Results

 9 files   9 suites   0s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit 13ff6d7.

♻️ This comment has been updated with latest results.

Copy link
Member

@HamBP HamBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM이요
코멘트만 확인해줘~

@mangbaam mangbaam merged commit 85c2587 into develop Oct 8, 2024
2 checks passed
@mangbaam mangbaam deleted the feature/Boolti-301 branch October 8, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

타인의 프로필
2 participants