Boolti-301 코드리뷰 반영

Nexters · Oct 8, 2024 · 13ff6d7 · 13ff6d7
1 parent db6ad98
commit 13ff6d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...entation/src/main/java/com/nexters/boolti/presentation/screen/profile/ProfileViewModel.kt b/...entation/src/main/java/com/nexters/boolti/presentation/screen/profile/ProfileViewModel.kt
@@ -63,11 +63,10 @@ class ProfileViewModel @Inject constructor(
     }
 
     private fun fetchOthersProfile(userCode: String) {
-        viewModelScope.launch {
+        viewModelScope.launch(recordExceptionHandler) {
             memberRepository.getMember(userCode).onSuccess { user ->
                 _uiState.update { it.copy(user = user) }
             }.onFailure {
-                it.printStackTrace()
                 event(ProfileEvent.Invalid)
             }
         }

diff --git a/...ation/src/main/java/com/nexters/boolti/presentation/screen/showdetail/ShowDetailScreen.kt b/...ation/src/main/java/com/nexters/boolti/presentation/screen/showdetail/ShowDetailScreen.kt
@@ -86,7 +86,7 @@ import com.nexters.boolti.presentation.util.UrlParser
 import kotlinx.coroutines.launch
 import timber.log.Timber
 import java.time.format.DateTimeFormatter
-import kotlin.math.roundToInt
+import kotlin.math.ceil
 
 @Composable
 fun ShowDetailScreen(
@@ -546,7 +546,7 @@ fun LazyListScope.CastTab(
                     val spacedBySize = 20.dp
                     val memberHeight = 46.dp
                     val spanCount = 2
-                    val rows = (team.members.size / spanCount.toFloat()).roundToInt()
+                    val rows = ceil(team.members.size / spanCount.toFloat())
 
                     /**
                      * 중첩 Lazy 레이아웃 처리를 위해 높이 고정 필요