MusicBrainz as Artwork Supplier #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
figured out how to do the checks myself now |
|
should be good to go |
|
oh shit |
|
Can you repush your changes to your fork and reopen this pr? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MusicBrainz has a large catalog of song metadata ready to be used. Instead of uploading the cover (which is expensive), we can use MusicBrainz to supply album cover instead (only if iTunes can't find the correct cover).
However, MusicBrainz search is kinda quirky in its search, and song that does not exist on their database (mainly unreleased or WIP titles) may get the wrong album cover, or none at all. I tried to solve this problem but it's not yet perfect.
This should solve issue #50.