Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom uploaded artwork for local files #50

Closed
Crunnie opened this issue Feb 2, 2023 · 2 comments · Fixed by #66
Closed

Use custom uploaded artwork for local files #50

Crunnie opened this issue Feb 2, 2023 · 2 comments · Fixed by #66
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Crunnie
Copy link

Crunnie commented Feb 2, 2023

I'm pretty sure Cider had a feature like that and it worked well, is it possible you could implement it into this as well?

@NextFire
Copy link
Owner

NextFire commented Feb 4, 2023

At first glance this would require to

  • get the music track location in the filesystem (AppleScript?)
  • extract the cover art (ffmpeg can do it - maybe use a wasm version to avoid the need to install another dependency on the user side)
  • push it to a hosting site (???)

I'm quite lazy to work on it right now but it looks doable. If anyone wants to develop it feel free to open a pr.

@NextFire NextFire added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2023
@sorae42
Copy link
Contributor

sorae42 commented Apr 26, 2023

You should use a music database (such as MusicBrainz) to find the cover album first since it's not very ideal to push the image to a hosting site everytime.

The database is very very huge so most of the cover art will be there

@NextFire NextFire added help wanted Extra attention is needed and removed good first issue Good for newcomers labels May 5, 2023
@NextFire NextFire linked a pull request Jul 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants