Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NWB schema 2.2.5 #1243

Merged
merged 6 commits into from
Jun 1, 2020
Merged

Add support for NWB schema 2.2.5 #1243

merged 6 commits into from
Jun 1, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented May 29, 2020

The current release of PyNWB, version 1.3.1, supports nwb-schema version 2.2.4. This PR adds support for nwb-schema bugfix version 2.2.5.

This PR tracks the dev branch of nwb-schema to ensure that changes in nwb-schema are compatible with PyNWB or are accompanied with corresponding changes in PyNWB. Those changes in PyNWB should be merged into this branch.

  • Update PyNWB to work with changes in nwb-schema:

    • Add schema validation CI.
    • Fix incorrect dims and shape for ImagingPlane.origin_coords and ImagingPlane.grid_spacing, and fix incorrect dims for TwoPhotonSeries.field_of_view.
  • Add integration tests that use ImagingPlane.origin_coords and ImagingPlane.grid_spacing

  • Run validation tests

  • Update changelog

  • After new version of nwb-schema is released, update the nwb-schema submodule to point to latest release: cd src/pynwb/nwb-schema/, git checkout dev, git pull origin dev, git fetch --tags, git checkout dev, cd ../../.., git add ., git commit -m "Update nwb-schema submodule to [new_release], and git push

After merging:

  • This branch should be merged into dev without squashing commits. Rebase if necessary.
  • Prepare for immediate bugfix release of PyNWB 1.3.2

@rly rly changed the title Schema 2.2.5 Add support for NWB schema 2.2.5 May 29, 2020
@rly rly marked this pull request as ready for review May 30, 2020 07:49
@rly rly requested review from ajtritt, bendichter and oruebel May 30, 2020 07:49
@rly rly merged commit b1e4697 into dev Jun 1, 2020
@rly rly deleted the schema_2.2.5 branch June 1, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants