-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ic_electrode with icephys_electrode on NWBFile #1200
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1200 +/- ##
=======================================
Coverage 68.22% 68.22%
=======================================
Files 37 37
Lines 2316 2316
Branches 405 405
=======================================
Hits 1580 1580
Misses 667 667
Partials 69 69
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
Co-Authored-By: Ryan Ly <[email protected]>
…eak backward compatibility as suggest by @rly
@rly this should be good to go now |
Motivation
Fix #1181 . replace the use of ic prefix as it has an ambigious meaning in the icephys domain. Use the prefix icephys instead
Specifically, this PR:
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number?