-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using ic
as abbreviation for icephys
#1181
Labels
category: enhancement
improvements of code or code behavior
Comments
@t-b sounds good. I'll address this as part of oruebel/ndx-icephys-meta#36 Closing this issue in favor of the one on the icephys extension. |
This is actually hard to address in the subclass. I'm reopening this issue and will submit a PR to fix this in PyNWB directly |
5 tasks
oruebel
added a commit
that referenced
this issue
Mar 3, 2020
* Deprecate ic_electrode params and funcs on NWBFile with icephys_electrode params and funcs. Fix #1181 * Replace use of ic_electrode with icephys_electrode in integration tests * Add tests to check that deprecation warnings are raised for ic_electrode uses * Replace use of ic_electrode with icephys_electrode in the ICEphys tutorial * Fix flake8 * Update tests/unit/test_icephys.py Co-Authored-By: Ryan Ly <[email protected]> * Simplify testing of warnings using self.assertWarnsWith as suggested by @rly * Mover icephys_electrodes NWBFile constructor arg to the end to not break backward compatibility as suggest by @rly Co-authored-by: Ryan Ly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See oruebel/ndx-icephys-meta#36.
We probably should also have
add_icephys_electrode
and show a warning foradd_ic_electrode
in pynwb. In addition the tutorials should use the the function call.The text was updated successfully, but these errors were encountered: