Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using ic as abbreviation for icephys #1181

Closed
t-b opened this issue Feb 7, 2020 · 2 comments · Fixed by #1200
Closed

Avoid using ic as abbreviation for icephys #1181

t-b opened this issue Feb 7, 2020 · 2 comments · Fixed by #1200
Labels
category: enhancement improvements of code or code behavior

Comments

@t-b
Copy link
Collaborator

t-b commented Feb 7, 2020

See oruebel/ndx-icephys-meta#36.

We probably should also have add_icephys_electrode and show a warning for add_ic_electrode in pynwb. In addition the tutorials should use the the function call.

@oruebel
Copy link
Contributor

oruebel commented Feb 7, 2020

@t-b sounds good. I'll address this as part of oruebel/ndx-icephys-meta#36 Closing this issue in favor of the one on the icephys extension.

@oruebel oruebel closed this as completed Feb 7, 2020
@oruebel
Copy link
Contributor

oruebel commented Feb 29, 2020

This is actually hard to address in the subclass. I'm reopening this issue and will submit a PR to fix this in PyNWB directly

@oruebel oruebel reopened this Feb 29, 2020
oruebel added a commit that referenced this issue Feb 29, 2020
oruebel added a commit that referenced this issue Mar 3, 2020
* Deprecate ic_electrode params and funcs on NWBFile with icephys_electrode params and funcs. Fix #1181

* Replace use of ic_electrode with icephys_electrode in integration tests

* Add tests to check that deprecation warnings are raised for ic_electrode uses

* Replace use of ic_electrode with icephys_electrode in the ICEphys tutorial

* Fix flake8

* Update tests/unit/test_icephys.py

Co-Authored-By: Ryan Ly <[email protected]>

* Simplify testing of warnings using self.assertWarnsWith as suggested by @rly

* Mover icephys_electrodes NWBFile constructor arg to the end to not break backward compatibility as suggest by @rly

Co-authored-by: Ryan Ly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants