Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpticalSeries API fix #1182

Closed
wants to merge 2 commits into from
Closed

OpticalSeries API fix #1182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc21246
update API to reflect changes to schema
bendichter Feb 8, 2020
f04a0b5
Update image.py
bendichter Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pynwb/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ class OpticalSeries(ImageSeries):
'field_of_view',
'orientation')

@docval(*get_docval(ImageSeries.__init__, 'name', 'data'), # required
@docval(*get_docval(ImageSeries.__init__, 'name'),
{'name': 'data', 'type': ('array_data', 'data'), 'shape': ([None] * 3, [None, None, None, 3]),
'doc': 'Images presented to subject, either grayscale or RGB'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be None as it is in ImageSeries (in the event that an external file is provided).

*get_docval(ImageSeries.__init__, 'unit', 'format'),
{'name': 'distance', 'type': 'float', 'doc': 'Distance from camera/monitor to target/eye.'}, # required
{'name': 'field_of_view', 'type': ('array_data', 'data', 'TimeSeries'), 'shape': ((2, ), (3, )), # required
Expand Down