Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpticalSeries API fix #1182

Closed
wants to merge 2 commits into from
Closed

OpticalSeries API fix #1182

wants to merge 2 commits into from

Conversation

bendichter
Copy link
Contributor

rly
rly requested changes Feb 8, 2020
View reviewed changes
src/pynwb/image.py
@docval(*get_docval(ImageSeries.__init__, 'name', 'data'), # required
@docval(*get_docval(ImageSeries.__init__, 'name'),
{'name': 'data', 'type': ('array_data', 'data'), 'shape': ([None] * 3, [None, None, None, 3]),
'doc': 'Images presented to subject, either grayscale or RGB'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be None as it is in ImageSeries (in the event that an external file is provided).

@codecov
Copy link

codecov bot commented Feb 8, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@cb5527b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #1182   +/-   ##
======================================
  Coverage       ?   67.86%           
======================================
  Files          ?       37           
  Lines          ?     2290           
  Branches       ?      400           
======================================
  Hits           ?     1554           
  Misses         ?      667           
  Partials       ?       69
Impacted Files Coverage Δ
src/pynwb/image.py 93.54% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb5527b...f04a0b5. Read the comment docs.

@rly
Copy link
Contributor

rly commented Feb 8, 2020 •
edited
Loading

Note that the PyNWB Windows-py3.5-min-req test fails sporadically for this error:

ValueError: cannot expose native-only dtype 'g' in non-native byte order '<' via buffer interface

For now, if this is the only error, the test should be re-run until it succeeds. I suspect one of our dependencies (probably h5py) fixes the failure in a later version.

@rly
Copy link
Contributor

rly commented Apr 11, 2020 •
edited
Loading

This change has been made in #1146. See the current dev code: https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/src/pynwb/image.py#L134-L136

@rly rly closed this Apr 11, 2020
@rly rly deleted the schema_update_222 branch April 11, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bendichter @rly