Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate manifold in favor of pixel_origin and pixel_deltas #305

Merged
merged 4 commits into from
Oct 7, 2019
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 34 additions & 4 deletions core/nwb.ophys.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ groups:
- null
- null
- 3
doc: "Physical position of each pixel. 'xyz' represents the position\
\ of the pixel relative to the defined coordinate space."
doc: "DEPRECATED Physical position of each pixel. 'xyz' represents the position\
\ of the pixel relative to the defined coordinate space. Deprecated in favor of pixel_origin and pixel_deltas."
quantity: '?'
attributes:
- name: conversion
Expand All @@ -224,9 +224,39 @@ groups:
- name: unit
dtype: text
default_value: meters
doc: Base unit of measurement for working with the data. The default value
is 'meters'.
doc: Base unit of measurement for working with the data. The default value is 'meters'.
required: false
- name: pixel_origin
dtype: float
dims:
- x, y
- x, y, z
shape:
- 2
- 3
doc: Location of the origin in x, y or x, y, z, in the specified unit.
required: false
attributes:
- name: unit
dtype: text
default_value: meters
doc: Measurement units for pixel_origin. The default value is 'meters'.
- name: pixel_deltas
dtype: float
dims:
- x, y
- x, y, z
shape:
- 2
- 3
doc: Space between pixels in x, y or x, y, z directions, in the specified unit.
Assumes imaging plane is a regular grid.
required: false
attributes:
- name: unit
dtype: text
default_value: meters
doc: Measurement units for pixel_deltas. The default value is 'meters'.
- name: reference_frame
dtype: text
doc: Describes position and reference frame of manifold based on position of
Expand Down