Deprecate manifold in favor of pixel_origin and pixel_deltas #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajtritt
previously approved these changes
Sep 17, 2019
|
@rly can we merge this? |
|
@bendichter I have been hung up on the names of the replacement datasets. To me, they are not intuitive enough and "pixel" is not appropriate for 3D data. What do you think about "origin_coords" and "grid_spacing" instead? |
|
@rly Yeah, "origin_coords" and "grid_spacing" are good names |
bendichter
approved these changes
Oct 7, 2019
|
@rly @bendichter I assume the idea is to then also rename |
|
@oruebel that's right. I think it will probably be easier to re-do that PR given how many merge conflicts there are |
|
Sounds good. |
oruebel
approved these changes
Oct 7, 2019
|
@bendichter can you make a new PR to replace NeurodataWithoutBorders/pynwb#576 ? |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing spec changes from NeurodataWithoutBorders/pynwb#576