Improve test coverage #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add function to create a filepath for saving tutorial nwb files in a fixed folder
Also, use misc.getTutorialNwbFilePath to create a filepath for saving tutorial nwb file
Some dates are assigned wrongly when Day, Month and Year are set individually, as the datetime object internally/silently adjusts month if day is not valid
Fix: Should not preallocate datetimeArray as it is not known beforehand whether the timestamp has a timezone or not (datetime.empty contrains to datetime w/o timezone)
Ensure test can be run from any current working directory, not just the matnwb repo folder
Simplyfy function by using mfilename instead of dbstack
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 88.99% 90.71% +1.71%
==========================================
Files 105 105
Lines 4645 4632 -13
==========================================
+ Hits 4134 4202 +68
+ Misses 511 430 -81 ☔ View full report in Codecov by Sentry. |
When writing test, also discovered a but in types.untyped.Set which is fixed
bendichter
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #580
Motivation
How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?