Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix definition of invoke transaction trace #631

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dkatzan
Copy link
Contributor

@dkatzan dkatzan commented Sep 30, 2024

This PR fixes a bug in invoke transaction trace described here

@dkatzan dkatzan force-pushed the feature/fix-invoke-trace branch from de39b93 to 7c74651 Compare September 30, 2024 19:56
@rianhughes rianhughes self-requested a review October 2, 2024 09:04
Copy link
Contributor

@rianhughes rianhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just need to fix the two failing testnet tests (we can do this on our end). Thanks for the PR!

@rianhughes rianhughes merged commit 4b606c6 into NethermindEth:main Oct 2, 2024
3 of 4 checks passed
@dkatzan
Copy link
Contributor Author

dkatzan commented Oct 2, 2024

Thx @rianhughes , will it be possible to create a new tag version from the main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants