Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - incorrect invoke transaction trace structure #630

Closed
dkatzan opened this issue Sep 30, 2024 · 0 comments
Closed

Bug - incorrect invoke transaction trace structure #630

dkatzan opened this issue Sep 30, 2024 · 0 comments

Comments

@dkatzan
Copy link
Contributor

dkatzan commented Sep 30, 2024

The go struct defined for the trace of an invoke transaction is incorrect, causing to missing data while parsing API results

specifically, the following field ExecInvocation struct defined here and used here
contains 2 inner fields, while the node result is slightly different, resulting with the inner FnInvocation to always be empty

Also, the relevant TestSimulateTransaction in mainnet is broken due to multiple reasons, part of them discussed here

I already have a draft work in progress, and will be happy to open a PR to fix these issues soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants