Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpServerRequest should provide a way to access Netty channel #214

Closed
NiteshKant opened this issue Aug 23, 2014 · 2 comments
Closed

HttpServerRequest should provide a way to access Netty channel #214

NiteshKant opened this issue Aug 23, 2014 · 2 comments
Assignees
@NiteshKant
Milestone
0.3.13

Comments

@NiteshKant
Copy link
Member

HttpServerRequest does not provide a way to get a handle to netty's ChannelHandlerContext as HttpServerResponse does.

This makes it awkard for code which wants an access to Channel details and is only interested in the request to either pass the ChannelHandlerContext directly or HttpServerResponse.
@NiteshKant NiteshKant added this to the 0.3.13 milestone Aug 23, 2014
@NiteshKant NiteshKant self-assigned this Aug 23, 2014
NiteshKant pushed a commit to NiteshKant/zuul that referenced this issue Aug 23, 2014
Provide access to netty's ChannelHandlerContext to EgressRequest and …
d84321b 
…IngressRequest.

When RxNetty provides a way to get ChannelHandlerContext from HttpServerRequest (Issue 214: ReactiveX/RxNetty#214) we will only need this in EgressRequest.
@NiteshKant NiteshKant mentioned this issue Aug 23, 2014
Merged
@NiteshKant NiteshKant changed the title HttpServerRequest should provide a way to access ChannelHandlerContext HttpServerRequest should provide a way to access Netty channel Sep 7, 2014
@NiteshKant
Copy link
Member Author

Returning a ChannelHandlerContext is ambiguous as it is unclear which ChannelHandler does this context belong to. So, instead it should return the Channel

@NiteshKant NiteshKant mentioned this issue Sep 7, 2014
Merged
NiteshKant added a commit that referenced this issue Sep 7, 2014
@NiteshKant
Merge pull request #227 from NiteshKant/0.x
136af0d 
Fixes #223 #225 #226 #214 #228 #230
@NiteshKant
Copy link
Member Author

PR #227 adds a method HttpServerRequest.getChannel()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiteshKant NiteshKant

Labels
None yet
Projects
None yet
Milestone
0.3.13
Development

No branches or pull requests
1 participant
@NiteshKant