-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactiveSocket metrics client/server #1236
Merged
mattrjacobs
merged 2 commits into
Netflix:master
from
mattrjacobs:reactivesocket-metric-client
Jun 12, 2016
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
...-stream/src/main/java/com/netflix/hystrix/contrib/reactivesocket/BasePayloadSupplier.java
This file was deleted.
Oops, something went wrong.
92 changes: 92 additions & 0 deletions
92
...et-event-stream/src/main/java/com/netflix/hystrix/contrib/reactivesocket/EventStream.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
/** | ||
* Copyright 2016 Netflix, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.netflix.hystrix.contrib.reactivesocket; | ||
|
||
import com.netflix.hystrix.config.HystrixConfigurationStream; | ||
import com.netflix.hystrix.contrib.reactivesocket.serialize.SerialHystrixConfiguration; | ||
import com.netflix.hystrix.contrib.reactivesocket.serialize.SerialHystrixDashboardData; | ||
import com.netflix.hystrix.contrib.reactivesocket.serialize.SerialHystrixMetric; | ||
import com.netflix.hystrix.contrib.reactivesocket.serialize.SerialHystrixRequestEvents; | ||
import com.netflix.hystrix.contrib.reactivesocket.serialize.SerialHystrixUtilization; | ||
import com.netflix.hystrix.metric.HystrixRequestEventsStream; | ||
import com.netflix.hystrix.metric.sample.HystrixUtilizationStream; | ||
import io.reactivesocket.Payload; | ||
import rx.Observable; | ||
|
||
import java.util.Arrays; | ||
import java.util.concurrent.atomic.AtomicBoolean; | ||
import java.util.function.Supplier; | ||
|
||
class EventStream implements Supplier<Observable<Payload>> { | ||
|
||
private final static int CONFIGURATION_DATA_INTERVAL_IN_MS = 500; | ||
private final static int UTILIZATION_DATA_INTERVAL_IN_MS = 500; | ||
|
||
private final Observable<Payload> source; | ||
private final AtomicBoolean isSourceCurrentlySubscribed = new AtomicBoolean(false); | ||
|
||
/* package-private */EventStream(Observable<Payload> source) { | ||
this.source = source | ||
.doOnSubscribe(() -> isSourceCurrentlySubscribed.set(true)) | ||
.doOnUnsubscribe(() -> isSourceCurrentlySubscribed.set(false)) | ||
.share() | ||
.onBackpressureDrop(); | ||
} | ||
|
||
@Override | ||
public Observable<Payload> get() { | ||
return source; | ||
} | ||
|
||
public static EventStream getInstance(EventStreamEnum eventStreamEnum) { | ||
final Observable<Payload> source; | ||
|
||
switch (eventStreamEnum) { | ||
case CONFIG_STREAM: | ||
source = new HystrixConfigurationStream(CONFIGURATION_DATA_INTERVAL_IN_MS) | ||
.observe() | ||
.map(SerialHystrixConfiguration::toBytes) | ||
.map(SerialHystrixMetric::toPayload); | ||
break; | ||
case REQUEST_EVENT_STREAM: | ||
source = HystrixRequestEventsStream.getInstance() | ||
.observe() | ||
.map(SerialHystrixRequestEvents::toBytes) | ||
.map(SerialHystrixMetric::toPayload); | ||
break; | ||
case UTILIZATION_STREAM: | ||
source = new HystrixUtilizationStream(UTILIZATION_DATA_INTERVAL_IN_MS) | ||
.observe() | ||
.map(SerialHystrixUtilization::toBytes) | ||
.map(SerialHystrixMetric::toPayload); | ||
break; | ||
case GENERAL_DASHBOARD_STREAM: | ||
source = HystrixDashboardStream.getInstance() | ||
.observe() | ||
.map(SerialHystrixDashboardData::toBytes) | ||
.map(SerialHystrixMetric::toPayload); | ||
break; | ||
default: | ||
throw new IllegalArgumentException("Unknown EventStreamEnum : " + eventStreamEnum); | ||
} | ||
|
||
return new EventStream(source); | ||
} | ||
|
||
public boolean isSourceCurrentlySubscribed() { | ||
return isSourceCurrentlySubscribed.get(); | ||
} | ||
} |
78 changes: 23 additions & 55 deletions
78
...vent-stream/src/main/java/com/netflix/hystrix/contrib/reactivesocket/EventStreamEnum.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding, why is the dashboard stream delay not configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Singletons for util/config stream to allow subscribers to share w/ archaius sounds like a good approach.