ReactiveSocket metrics client/server #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattrjacobs
commented
Jun 10, 2016
mattrjacobs
commented
- Client/Server in hystrix-examples-reactivesocket
- Improvements to HystrixCommandAsyncDemo
- Bugfixes/polishing to hystrix-reactivesocket-metric-stream. Sources should support arbitrary sharing between 0-n subscribers that may come and go. When subscriber count drops to 0, source does no work
* Client/Server in hystrix-examples-reactivesocket * Improvements to HystrixCommandAsyncDemo * Bugfixes/polishing to hystrix-reactivesocket-metric-stream. Sources should support arbitrary sharing between 0-n subscribers that may come and go. When subscriber count drops to 0, source does no work
|
/cc @robertroeser @neerajrj @nickmahilani - Could you take a look? |
| collapserConfigMap.put(collapserKey, collapserConfig); | ||
| } | ||
| } catch (IOException ioe) { | ||
| System.out.println("IO Exception : " + ioe); |
|
Good catch @nickmahilani - just found 2 others as well |
| .map(SerialHystrixMetric::toPayload); | ||
| break; | ||
| case GENERAL_DASHBOARD_STREAM: | ||
| source = HystrixDashboardStream.getInstance() |
There was a problem hiding this comment.
For my understanding, why is the dashboard stream delay not configurable?
There was a problem hiding this comment.
Singletons for util/config stream to allow subscribers to share w/ archaius sounds like a good approach.
|
Right now, the utilization and configuration streams always accept a stream delay and are non-singletons. Looking back, this is probably a mistake as it makes it harder for multiple subscribers to share. I think there are 2 more tasks (coming next week):
|
|
just couple minor comments, PR looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.