Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify_log_entry call #53

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix verify_log_entry call #53

merged 1 commit into from
May 22, 2023

Conversation

karim-en
Copy link
Collaborator

@karim-en karim-en commented May 16, 2023 •
edited
Loading

Description

  • Improve code readability.
  • Fix arguments type for the cross call verify_log_entry. The tests didn't fail because the mocked pub fn verify_log_entry didn't accept any arguments, so the tests failed with error ExecutionError("Smart contract panicked: Callback computation 0 was not successful") on adding correct arguments to it.

@karim-en karim-en requested a review from mrLSD as a code owner May 16, 2023 22:58
@sept-en sept-en requested a review from olga24912 May 16, 2023 23:13
mrLSD
mrLSD reviewed May 17, 2023
View reviewed changes
Copy link
Collaborator

@mrLSD mrLSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sept-en @karim-en any reason remove field skip_bridge_call for proof for verification?

eth-connector/src/connector_impl.rs Show resolved Hide resolved
eth-connector/src/connector_impl.rs Show resolved Hide resolved
eth-connector/src/lib.rs Show resolved Hide resolved
eth-connector/src/lib.rs Show resolved Hide resolved
@mrLSD mrLSD requested a review from sept-en May 17, 2023 00:45
@mrLSD mrLSD added the enhancement New feature or request label May 17, 2023
@mrLSD mrLSD added this to the v0.5.1 milestone May 17, 2023
@mrLSD mrLSD requested a review from aleksuss May 17, 2023 00:46
aleksuss
aleksuss approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@aleksuss aleksuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

eth-connector/src/lib.rs Show resolved Hide resolved
eth-connector/src/connector_impl.rs Show resolved Hide resolved
@mrLSD mrLSD mentioned this pull request May 17, 2023
Closed
@mrLSD mrLSD merged commit cb1765c into master May 22, 2023
@mrLSD mrLSD deleted the review branch May 22, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrLSD mrLSD mrLSD left review comments

@olga24912 olga24912 olga24912 approved these changes

@aleksuss aleksuss aleksuss approved these changes

@sept-en sept-en Awaiting requested review from sept-en

Assignees

@mrLSD mrLSD

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@karim-en @mrLSD @aleksuss @olga24912