Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary Initialization verification #43

Closed
olga24912 opened this issue May 10, 2023 · 3 comments
Closed

Unnecessary Initialization verification #43

olga24912 opened this issue May 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@olga24912
Copy link
Collaborator

No need for check require!(!env::state_exists(), "Already initialized");. It is already checked in #[init] macro.

https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L173

Commit in near_sdk where the behavior has been changed:
near/near-sdk-rs@18b8f8f
@mrLSD
Copy link
Collaborator

mrLSD commented May 15, 2023

@olga24912 Proof?

@mrLSD
Copy link
Collaborator

mrLSD commented May 17, 2023

#53

@mrLSD
Copy link
Collaborator

mrLSD commented May 22, 2023

Refactored at #53

@mrLSD mrLSD closed this as completed May 22, 2023
@mrLSD mrLSD added the enhancement New feature or request label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrLSD @olga24912