A card based projects list in Vue #839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanil
reviewed
Nov 18, 2024
aanil
reviewed
Nov 18, 2024
aanil
reviewed
Nov 18, 2024
aanil
reviewed
Nov 18, 2024
| requests.get(user_url, headers=headers).content.rstrip().decode("ascii") | ||
| ) | ||
| self.genstat_defaults = decoder.decode(json_user) | ||
| self.genstat_defaults = self.gs_users_db[genstat_defaults_doc_id] |
There was a problem hiding this comment.
I wonder if there was a reason it was so roundabout before?
There was a problem hiding this comment.
Hmmm, yeah. Special characters perhaps?
There was a problem hiding this comment.
Or a remnant from older python versions?
aanil
reviewed
Nov 18, 2024
| @@ -150,19 +158,28 @@ def project_summary_data(self, row): | |||
| row.value["contact"] = ( | |||
| ord_det["owner"]["name"] + ": " + ord_det["owner"]["email"] | |||
| ) | |||
| field_sources["contact"] = ( | |||
| "LIMS (researcher.email) and Order Portal, formatted by Genomics Status (backend)" | |||
There was a problem hiding this comment.
I guess its one or the other? I don't think researcher.email is updated any longer
There was a problem hiding this comment.
Maybe you can suggest a better source explanation? I'm a bit uncertain of the logics myself actually
aanil
reviewed
Nov 18, 2024
| elif "fields" in ord_det: | ||
| if row.value["contact"] == ord_det["fields"]["project_lab_email"]: | ||
| row.value["contact"] = ( | ||
| ord_det["fields"]["project_lab_name"] | ||
| + ": " | ||
| + ord_det["fields"]["project_lab_email"] | ||
| ) | ||
| field_sources["contact"] = ( |
There was a problem hiding this comment.
Could we define it in a single place instead of in 3 places? Maybe with an if
Suggested change
| field_sources["contact"] = ( | |
| if 'contact' in row.value: | |
| field_sources["contact"] = ( |
There was a problem hiding this comment.
I think my reasoning was to keep it close to where the value is set so that it is harder to forget to update it when a definition is changed. But maybe I can actually use these three different cases to show where it was actually taken from in each case?
aanil
reviewed
Nov 18, 2024
| @@ -173,6 +190,9 @@ def project_summary_data(self, row): | |||
| queued = row.value["queued"] | |||
| diff = now - dateutil.parser.parse(queued) | |||
| row.value["days_in_production"] = diff.days | |||
| field_sources["days_in_production"] = ( | |||
There was a problem hiding this comment.
Same here, if it could be defined in a single place
aanil
reviewed
Nov 18, 2024
| @@ -477,8 +505,17 @@ def list_projects(self, filter_projects="all"): | |||
| final_projects[proj_id].get(end_date), | |||
| ) | |||
|
|
|||
| if len(projects_with_agreements[proj_id]) > 0: | |||
| final_projects[proj_id]["has_agreements"] = True | |||
| # Create slices of 200 projects each to get the agreements for | |||
There was a problem hiding this comment.
Why slices of 200? Does it take too much time otherwise?
There was a problem hiding this comment.
Good question. I think it's fairly arbitrary. 200 seems to work. Larger number could become too large return body and a smaller number results in more requests.
aanil
reviewed
Nov 18, 2024
| "_pipeline_": "Pipeline MultiQC", | ||
| } | ||
| for report_type in self.get_multiqc(project, read_file=False).keys(): | ||
| report_name = type_to_name.get(report_type, report_type) |
There was a problem hiding this comment.
type_to_name.get(report_type, report_type) What does this get do?
aanil
reviewed
Nov 19, 2024
| } | ||
| }, | ||
| methods: { | ||
| async fetchAllRunningNotes(partition_id) { |
There was a problem hiding this comment.
Is async required here? I'm not quire sure, but it seems like you use async with await?
aanil
reviewed
Nov 19, 2024
| /* Create a new text by replacing the word where the @ was found with the @user */ | ||
| let new_text = text_before_cursor.substring(0, text_before_cursor.length - current_word.length) + '@' + user + ' ' + text_after_cursor.substring(current_word_after.length); | ||
| this.form_note_text = new_text; | ||
| this.user_suggestions = []; |
There was a problem hiding this comment.
This would leave the cursor in the textarea
Suggested change
| this.user_suggestions = []; | |
| this.user_suggestions = []; | |
| form_note_text_field.focus(); |
aanil
reviewed
Nov 19, 2024
|
|
||
| if (current_word.startsWith('@')) { | ||
| current_word = current_word.substring(1).toLowerCase(); | ||
| let user_suggestions = this.all_users.filter(user => user.startsWith(current_word)); |
There was a problem hiding this comment.
This could return matches of surname too
Suggested change
| let user_suggestions = this.all_users.filter(user => user.startsWith(current_word)); | |
| let user_suggestions = this.all_users.filter(user => user.includes(current_word)); |
aanil
reviewed
Nov 19, 2024
Comment on lines
+195
to
+196
| toggleFormCategory(category) { | ||
| if (this.form_categories.includes(category)) { |
There was a problem hiding this comment.
Suggested change
| toggleFormCategory(category) { | |
| if (this.form_categories.includes(category)) { | |
| toggleFormCategory(event, category) { | |
| event.preventDefault(); | |
| if (this.form_categories.includes(category)) { |
aanil
reviewed
Nov 19, 2024
Comment on lines
+219
to
+227
| <button class="btn btn-sm btn-inf mr-2" value="Decision" data-toggle="tooltip" title="For when an executive decision has been made" @click="toggleFormCategory('Decision')">Decision <span class="fa fa-thumbs-up"></span></button> | ||
| <button class="btn btn-sm btn-succe mr-2" value="Lab" data-toggle="tooltip" title="For lab-related work" @click="toggleFormCategory('Lab')">Lab <span class="fa fa-flask"></span></button> | ||
| <button class="btn btn-sm btn-warn mr-2" value="Bioinformatics" data-toggle="tooltip" title="For all bioinformatics work" @click="toggleFormCategory('Bioinformatics')">Bioinformatics <span class="fa fa-laptop-code"></span></button> | ||
| <button class="btn btn-sm btn-usr mr-2" value="User Communication" data-toggle="tooltip" title="For notes influenced by user-contact" @click="toggleFormCategory('User Communication')">User Communication <span class="fa fa-people-arrows"></span></button> | ||
| <button class="btn btn-sm btn-dang mr-2" value="Administration" data-toggle="tooltip" title="For notes involving documentation" @click="toggleFormCategory('Administration')">Administration <span class="fa fa-folder-open"></span></button> | ||
| <button class="btn btn-sm btn-imp mr-2" value="Important" data-toggle="tooltip" title="For when a note needs to be highlighted" @click="toggleFormCategory('Important')">Important <span class="fa fa-exclamation-circle"></span></button> | ||
| <button class="btn btn-sm btn-devi mr-2" value="Deviation" data-toggle="tooltip" title="For notes about a deviation" @click="toggleFormCategory('Deviation')">Deviation <span class="fa fa-frown"></span></button> | ||
| <button class="btn btn-sm btn-inv mr-2" value="Invoice" data-toggle="tooltip" title="For notes about an invoice" @click="toggleFormCategory('Invoice')">Invoicing <span class="fa fa-file-invoice-dollar"></span></button> | ||
| <button class="btn btn-sm btn-sticky" value="Sticky" data-toggle="tooltip" title="For sticky notes" @click="toggleFormCategory('Sticky')">Sticky <span class="fa fa-note-sticky"></span></button> |
There was a problem hiding this comment.
Suggested change
| <button class="btn btn-sm btn-inf mr-2" value="Decision" data-toggle="tooltip" title="For when an executive decision has been made" @click="toggleFormCategory('Decision')">Decision <span class="fa fa-thumbs-up"></span></button> | |
| <button class="btn btn-sm btn-succe mr-2" value="Lab" data-toggle="tooltip" title="For lab-related work" @click="toggleFormCategory('Lab')">Lab <span class="fa fa-flask"></span></button> | |
| <button class="btn btn-sm btn-warn mr-2" value="Bioinformatics" data-toggle="tooltip" title="For all bioinformatics work" @click="toggleFormCategory('Bioinformatics')">Bioinformatics <span class="fa fa-laptop-code"></span></button> | |
| <button class="btn btn-sm btn-usr mr-2" value="User Communication" data-toggle="tooltip" title="For notes influenced by user-contact" @click="toggleFormCategory('User Communication')">User Communication <span class="fa fa-people-arrows"></span></button> | |
| <button class="btn btn-sm btn-dang mr-2" value="Administration" data-toggle="tooltip" title="For notes involving documentation" @click="toggleFormCategory('Administration')">Administration <span class="fa fa-folder-open"></span></button> | |
| <button class="btn btn-sm btn-imp mr-2" value="Important" data-toggle="tooltip" title="For when a note needs to be highlighted" @click="toggleFormCategory('Important')">Important <span class="fa fa-exclamation-circle"></span></button> | |
| <button class="btn btn-sm btn-devi mr-2" value="Deviation" data-toggle="tooltip" title="For notes about a deviation" @click="toggleFormCategory('Deviation')">Deviation <span class="fa fa-frown"></span></button> | |
| <button class="btn btn-sm btn-inv mr-2" value="Invoice" data-toggle="tooltip" title="For notes about an invoice" @click="toggleFormCategory('Invoice')">Invoicing <span class="fa fa-file-invoice-dollar"></span></button> | |
| <button class="btn btn-sm btn-sticky" value="Sticky" data-toggle="tooltip" title="For sticky notes" @click="toggleFormCategory('Sticky')">Sticky <span class="fa fa-note-sticky"></span></button> | |
| <button class="btn btn-sm btn-inf mr-2" value="Decision" data-toggle="tooltip" title="For when an executive decision has been made" @click="toggleFormCategory($event, 'Decision')">Decision <span class="fa fa-thumbs-up"></span></button> | |
| <button class="btn btn-sm btn-succe mr-2" value="Lab" data-toggle="tooltip" title="For lab-related work" @click="toggleFormCategory($event, 'Lab')">Lab <span class="fa fa-flask"></span></button> | |
| <button class="btn btn-sm btn-warn mr-2" value="Bioinformatics" data-toggle="tooltip" title="For all bioinformatics work" @click="toggleFormCategory($event, 'Bioinformatics')">Bioinformatics <span class="fa fa-laptop-code"></span></button> | |
| <button class="btn btn-sm btn-usr mr-2" value="User Communication" data-toggle="tooltip" title="For notes influenced by user-contact" @click="toggleFormCategory($event, 'User Communication')">User Communication <span class="fa fa-people-arrows"></span></button> | |
| <button class="btn btn-sm btn-dang mr-2" value="Administration" data-toggle="tooltip" title="For notes involving documentation" @click="toggleFormCategory($event, 'Administration')">Administration <span class="fa fa-folder-open"></span></button> | |
| <button class="btn btn-sm btn-imp mr-2" value="Important" data-toggle="tooltip" title="For when a note needs to be highlighted" @click="toggleFormCategory($event, 'Important')">Important <span class="fa fa-exclamation-circle"></span></button> | |
| <button class="btn btn-sm btn-devi mr-2" value="Deviation" data-toggle="tooltip" title="For notes about a deviation" @click="toggleFormCategory($event, 'Deviation')">Deviation <span class="fa fa-frown"></span></button> | |
| <button class="btn btn-sm btn-inv mr-2" value="Invoice" data-toggle="tooltip" title="For notes about an invoice" @click="toggleFormCategory($event, 'Invoice')">Invoicing <span class="fa fa-file-invoice-dollar"></span></button> | |
| <button class="btn btn-sm btn-sticky" value="Sticky" data-toggle="tooltip" title="For sticky notes" @click="toggleFormCategory($event, 'Sticky')">Sticky <span class="fa fa-note-sticky"></span></button> |
There was a problem hiding this comment.
Clicking on the button reloads the page otherwise.
aanil
reviewed
Nov 19, 2024
| </div> | ||
| <div class="row"> | ||
| <div class="col-md-6 text-right"> | ||
| <button type="button" class="btn btn-link" data-toggle="modal" data-target="#markdown_help">Markdown Help</button> |
aanil
reviewed
Nov 19, 2024
| </template> | ||
| </div> | ||
| <div class="card-body bi-project-note-text"> | ||
| <div class="running-note-body text-muted" v-html="formatted_note"/> |
There was a problem hiding this comment.
Any reason running note text is set totext-muted?
aanil
reviewed
Nov 19, 2024
| copy_to_clipboard(event, text) { | ||
| // Copy text to clipboard | ||
| navigator.clipboard.writeText(text).then(function() { | ||
| console.log('Async: Copying to clipboard was successful!'); |
There was a problem hiding this comment.
Do we need to print it to console? 😄 Since its shown in the tooltip, I mean
aanil
reviewed
Nov 19, 2024
| } else if (this.project_data['status'] == 'Reception Control') { | ||
| return 'bg-warning' | ||
| } else if (this.project_data['status'] == 'Pending') { | ||
| return 'bg-light text-dark' |
There was a problem hiding this comment.
I feel bg-light is a bit too light, its hardly visible
aanil
reviewed
Nov 19, 2024
| await sleep(1000); | ||
| } | ||
| axios | ||
| .post('/api/v1/latest_sticky_run_note', post_body) |
There was a problem hiding this comment.
If we are just fetching running notes, shouldn't this be get?
aanil
reviewed
Nov 19, 2024
| URL: /api/v1/latest_sticky_run_note) | ||
| """ | ||
|
|
||
| def post(self): |
There was a problem hiding this comment.
If we are only fetching data, this should be get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boom! This will be the firs launch of a url project_cards. This is a Trello-inspired board showing our active projects. It's coupled with a new version of the project page (not finished by far).
Main features:
Placeholder code for websocket connection. This can be used in the future to propagate changes in projects without polling or refreshing the page.
Since the project page is still incomplete, this is only a preliminary launch. However, hopefully the project cards page is still useful for e.g. applications lab to have overview of their projects.