Fix library ID handling during patron auth #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attemoi
force-pushed
the
bugfix/simplye-263/patron-auth
branch
from
b650580 to
2aeefe8
Compare
sylvain-degeilh-lingsoft
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current logic is flawed in that it does not recognize if a patron has already signed in and been assigned to a library. When authenticating, the patron lookup is filtered by library id (of the default library), and the existing patron is not found.
Now changed to search for patrons within any library so it finds (and updates) the existing patron instead of trying to create a duplicate.
This issue was introduced in an earlier PR (#30).