-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMPLYE-261 - Municipality and consortium management #30
Conversation
1f0bd6a
to
5a41973
Compare
Assign each patron and admin to a library based on the municipality code received during authentication.
2d9082f
to
16747bb
Compare
api/admin/controller/sign_in.py
Outdated
@@ -94,7 +96,9 @@ def ekirjasto_auth_finish(self): | |||
if isinstance(user_info, ProblemDetail): | |||
return user_info | |||
|
|||
circulation_role = self._to_circulation_role(user_info.role) | |||
circulation_role = self._to_circulation_role( | |||
self._db, user_info.role, user_info.municipality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is still pending some discussion/decisions on how the two municipality fields (municipality
and municipalities
) we get during authentication (with user info) will be managed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now handled. The singular municipality
field will be used for patrons and municipalities
field for admins and librarians to determine which libraries they can manage.
154b065
to
74dd78c
Compare
Add new option under library settings that allows syncing library data automatically from Kirkanta and Kansallinen koodistopalvelu.
it's not super clear currently in the admin UI that collections defined for default library are applied to all other libraries. By passing this extra field we can then display some extra info on the admin UI side.
The user info from authentication has two fields, `municipality` and `municipalities`. The first is used to link patrons to a consortium, and second one is used for admins and librarians to determine which libraries they can manage.
Some updated information:
|
@sylvain-degeilh-lingsoft, thanks for the update!
This one is already supported, as we can manage a library for those municipalities manually, without automatic sync. If needed, can be automated further with a separate PR. |
Description
Goal
-> License pools shared between all Kimppas
-> All patrons will have access to the same works regardless of Kimppa
Available data
Solution
ekirjasto_consortium_monitor
) to automatically keep libraries (i.e. Kimppas) synced with Kirkanta dataOther notes
000
, i.e. they won't belong to any KimppaMotivation and Context
https://docs.google.com/document/d/1oq9_YBgfY5JMh_zDROZyDHts5FZfH_PQ1FRz1IVxv-k/edit#heading=h.y5cwsxdy2zq5
https://jira.lingsoft.fi/browse/SIMPLYE-261 - Prepare the data foundation to handle municipality and library patron info
https://jira.lingsoft.fi/browse/SIMPLYE-262 - Implement the mapping between municipalities and libraries
https://jira.lingsoft.fi/browse/SIMPLYE-263 - Implement custom lane management for local librarians
Checklist