Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplye 210 #22

Merged
merged 21 commits into from
Mar 14, 2024
Merged

Simplye 210 #22

merged 21 commits into from
Mar 14, 2024

Conversation

jompu
Copy link
Contributor

@jompu jompu commented Mar 9, 2024

Description

  • Enabled translation mecanishm with PO files for languages en, fi and sv.
  • set response header "Content-Language"
  • Translating entrypoints (product filters), required to add the strings for translation.
  • Translating errors (ProblemDetail in code), was already enabled.
  • Translating Lane filters, was already enabled.
  • Translating genres support was added.

How Has This Been Tested?

With curl commands and iOS application.

Checklist

  • All new and existing tests passed.

jompu added 13 commits February 19, 2024 22:43
@jompu
Added langugage support for en, fi and sv.
16918c1
@jompu
Added transaltion support for the title of top level acquisition link.
2540f57
@jompu
Added Content-Language header to API responses.
84c8b8a
@jompu
Make entrypoint link titles translatable.
1081ca9
@jompu
Localize classifiers
3365cdd
@jompu
Added new classifier strings to babel.
3be2475
@jompu
Added transifex configuration.
c09dac5
@jompu
Collect genres for translation and translate them when constructing f…
f467677 
…eed antry of a work.
@jompu
Merge remote-tracking branch 'origin/SIMPLYE-210-translation-strings-…
2b531b1 
…freeze' into SIMPLYE-210
@jompu
Merge remote-tracking branch 'origin/main' into SIMPLYE-210
b058811
@jompu
Collect latest translations.
7a53611
@jompu
Fix for failing test.
aa360ce
@jompu
Set user's locale for E-kirjasto authentication provider's links in t…
7162247 
…he authentication document. Also the cache for authentication document was disabled as the locale changes based on the user.
@sylvain-degeilh-lingsoft
Copy link
Contributor

Anything to fix in order to pass these failing tests?

@jompu
Copy link
Contributor Author

jompu commented Mar 14, 2024

Anything to fix in order to pass these failing tests?

Fixed

@jompu jompu merged commit 9823333 into main Mar 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvain-degeilh-lingsoft sylvain-degeilh-lingsoft sylvain-degeilh-lingsoft approved these changes

@attemoi attemoi Awaiting requested review from attemoi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jompu @sylvain-degeilh-lingsoft