Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add tests for legacy and per-thread default streams #1201

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

rongou
Copy link
Collaborator

@rongou rongou commented Jun 19, 2020

Some simple tests to verify we are getting the correct default streams. Also added the capability to pass in additional compile flags for tests.

Part of NVIDIA/cccl#732.

@brycelelbach

@alliepiper
Copy link
Collaborator

The tests LGTM, but the CMake stuff is going to conflict with #1184.

We'll also need to update the Makefiles to make sure that this works with our current internal CI (which does not use CMake).

I'll take care of these issues once #1184 is merged and start testing integrating then.

Thanks for the patch!

@alliepiper alliepiper self-assigned this Jun 22, 2020
@alliepiper alliepiper added blocked Cannot make progress. only: cmake CMake changes only. Doesn't need internal NVIDIA CI. labels Jun 22, 2020
@brycelelbach brycelelbach changed the title add tests for legacy and per-thread default streams Add tests for legacy and per-thread default streams Jun 30, 2020
@brycelelbach brycelelbach modified the milestones: 1.9.10-1, 1.10.0 Jun 30, 2020
@rongou
Copy link
Collaborator Author

rongou commented Jul 10, 2020

@allisonvacanti merged with the new cmake files. Please take another look. Thanks!

@brycelelbach brycelelbach changed the base branch from master to main July 11, 2020 04:20
@alliepiper
Copy link
Collaborator

@rongou Thanks for the updates and sorry about the long wait.

In general this looks ok, but I'll have to rethink this a bit from the CMake side since we need to support CUDA compilers besides nvcc. I'm planning to take a look at this sometime this week.

@alliepiper alliepiper force-pushed the stream-tests branch 3 times, most recently from 078c02b to 7b1306d Compare July 16, 2020 17:08
@alliepiper
Copy link
Collaborator

I'm fairly sure this will work on all of the NVIDIA compilers, just waiting on the nvc++ folks to confirm what their default behavior is.

@alliepiper
Copy link
Collaborator

Rebased on current main, restored original author metadata, and submitted DVS CL 28862904.

@alliepiper alliepiper added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). and removed blocked Cannot make progress. only: cmake CMake changes only. Doesn't need internal NVIDIA CI. labels Jul 27, 2020
@alliepiper alliepiper self-requested a review July 28, 2020 22:34
@alliepiper alliepiper merged commit 52d940f into NVIDIA:main Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants