-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for per-thread default streams #732
Comments
Great idea! I'm seeing some synchronization issues in spark with per-thread default stream enabled, but not sure if the problem is with thrust or cudf (or both). Having some test coverage would definitely help. |
@brycelelbach I think I might have some time to work on this. Do you have any idea on how to test this effectively? |
Spawn a thread with We should probably also make this a CMake option so we can run tests with and without this. |
Ah yes I think we can easily test that we are using the correct streams. I'm also wondering if we can test the multi-threaded behavior, checking for race conditions, etc. |
As discussed in today's meeting, we want to update both the per-thread stream and RDC options as follows:
This will give each build some coverage, while letting us add wider coverage with CI. |
PR NVIDIA/thrust#1128 added support for using the per-thread default stream in Thrust if it has been requested via
CUDA_API_PER_THREAD_DEFAULT_STREAM
. We don't have any tests for this codepath, or in fact any multi-threaded host tests. We should probably add some.The text was updated successfully, but these errors were encountered: