Add support for parsing strings as dates in from_json [databricks]
#9666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <[email protected]>
andygrove
changed the title
from_jsonfrom_json [databricks]
|
build |
andygrove
changed the title
from_json [databricks]from_json [databricks]
|
build |
|
build |
revans2
reviewed
Nov 15, 2023
sql-plugin/src/main/scala/org/apache/spark/sql/catalyst/json/rapids/GpuJsonScan.scala
Outdated
Show resolved
Hide resolved
revans2
approved these changes
Nov 16, 2023
revans2
requested changes
Nov 16, 2023
revans2
reviewed
Nov 16, 2023
| "", | ||
| "yyyy-MM-dd", | ||
| # https://github.com/NVIDIA/spark-rapids/issues/9667 | ||
| pytest.param("dd/MM/yyyy", marks=pytest.mark.allow_non_gpu('ProjectExec')), |
There was a problem hiding this comment.
nit: I meant a separate test that does a fallback check, but I think this is okay.
This was referenced Nov 16, 2023
revans2
previously approved these changes
Nov 17, 2023
|
build |
|
build |
|
build |
|
build |
|
build |
1 similar comment
|
build |
revans2
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9590 (I plan on creating a separate PR for timestamp support).
Changes in this PR:
datetype infrom_json, but only if the defaultdateFormatofyyyy-MM-ddis used. There is a follow-up issue [FEA][JSON] Add support for non defaultdateFormatinfrom_json#9667 for supporting other formats.