Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timestamp in from_json [databricks] #9720

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Support timestamp in from_json [databricks] #9720

merged 7 commits into from
Nov 21, 2023

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Nov 15, 2023 •
edited
Loading

Closes #9590

Overview of PR:

  • Add support for timestamp when parsing JSON with from_json
  • Add tests
  • Update compatibility guide

@andygrove andygrove self-assigned this Nov 15, 2023
@andygrove andygrove mentioned this pull request Nov 15, 2023
Open
@andygrove andygrove changed the title [WIP] Support timestamp in from_json [WIP] Support timestamp in from_json [databricks] Nov 20, 2023
@andygrove andygrove changed the title [WIP] Support timestamp in from_json [databricks] Support timestamp in from_json [databricks] Nov 20, 2023
@andygrove andygrove marked this pull request as ready for review November 20, 2023 17:14
@andygrove andygrove added the feature request New feature or request label Nov 20, 2023
@andygrove
Copy link
Contributor Author

build

@andygrove
Copy link
Contributor Author

build

1 similar comment
@andygrove
Copy link
Contributor Author

build

revans2
revans2 reviewed Nov 21, 2023
View reviewed changes
docs/compatibility.md Outdated Show resolved Hide resolved
integration_tests/src/main/python/json_test.py Show resolved Hide resolved
@andygrove
Copy link
Contributor Author

build

@andygrove andygrove merged commit f354ddf into NVIDIA:branch-23.12 Nov 21, 2023
37 checks passed
@andygrove andygrove deleted the from-json-timestamp branch November 21, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@andygrove andygrove

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA][JSON] Support temporal types in from_json
2 participants
@andygrove @revans2