Disable asserts for non-empty nulls #8183
Conversation
Signed-off-by: Raza Jafri <[email protected]>
razajafri
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
Signed-off-by: Raza Jafri <[email protected]>
| export PYSP_TEST_spark_driver_extraJavaOptions="-ea -Duser.timezone=UTC -Ddelta.log.cacheSize=10 $COVERAGE_SUBMIT_FLAGS" | ||
| export PYSP_TEST_spark_executor_extraJavaOptions='-ea -Duser.timezone=UTC' | ||
| export PYSP_TEST_spark_driver_extraJavaOptions="-ea -Duser.timezone=UTC -da:ai.rapids.cudf.AssertEmptyNulls -Ddelta.log.cacheSize=10 $COVERAGE_SUBMIT_FLAGS" | ||
| export PYSP_TEST_spark_executor_extraJavaOptions='-ea -da:ai.rapids.cudf.AssertEmptyNulls -Duser.timezone=UTC' |
There was a problem hiding this comment.
Do we have a list of tests that are failing? If so please file issues to fix all of them. If not, then we need a follow on issue to get that list. Turning off the asserts is only a temporary fix.
There was a problem hiding this comment.
I'll file an issue for md5. I can reproduce it fairly simply
There was a problem hiding this comment.
I created an umbrella issue #8183 rather than creating an issue for each test. I haven't run the entire suite of integration tests to know each test but that will be my next task. The only unit test that I have seen fail is md5 as well. If you create an issue please assign it to me
There was a problem hiding this comment.
I ran a lot of the integration tests. I will file issues for what I find there.
|
converted to draft to avoid accidentally kicking off of pre-merge. Will put it back in the original state once spark-rapids-jni build has been successful |
|
build |
|
Related bug in cuDF rapidsai/cudf#13225. |
This reverts commit 6f38189. Signed-off-by: Raza Jafri <[email protected]>
This reverts commit 6f38189. Signed-off-by: Raza Jafri <[email protected]>
This PR fixes the plugin build by disabling asserts for checking non-empty nulls.
I have filed a follow-on issue to have a proper fix, where we will only disable this assert for tests that are failing.